Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Include markdown tables #146

Open
tysino opened this issue Jan 11, 2023 · 5 comments
Open

[Feature] Include markdown tables #146

tysino opened this issue Jan 11, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@tysino
Copy link

tysino commented Jan 11, 2023

Is your feature request related to a problem? Please describe.
Weirdly, table syntax is recognized, but the formatting characters (|, -) are just removed in the rendered markdown.

Describe the solution you'd like
Implement github-style rendered tables (maybe just a library change is necessary).

Describe alternatives you've considered
Other option: show the formatting characters in the rendered markdown (which is ugly, but at least not unexpected).

Additional context
The Android client for Nextcloud notes supports this, if you are looking for a library.

PS: Thank you for the awesome app.

@tysino tysino added the enhancement New feature or request label Jan 11, 2023
@patrickunterwegs
Copy link
Member

Thanks @tysino for the feedback 🙂

@ArnyminerZ , would you maybe have the time to check this out after your exam period? Could we move this to the MarkdownText project? 🙂

@ArnyminerZ
Copy link
Collaborator

The issue here is that we are working with AnnotatedString, I don't see how we could create a table only with characters. Maybe with some ASCII magic... But we should investigate a little bit. The other way could be generating an image and rendering it... I'll take a look at the options. We should move the issue to MarkdownText then.
The good thing is that the table is already being parsed by the library, so it's just a rendering issue.

@patrickunterwegs
Copy link
Member

Yes, I also wouldn't go too far with the markdown support, but maybe we can also just keep the tags for now!

@ArnyminerZ
Copy link
Collaborator

I have now released MarkdownText 1.2.3, it fixes temporally the issue by rendering the table as raw Markdown. Once I finish exams I will work on a proper implementation of tables.

@patrickunterwegs
Copy link
Member

Thanks @ArnyminerZ 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants