Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize inventory item lookup #46

Open
Terkwood opened this issue Apr 1, 2019 · 1 comment
Open

Sanitize inventory item lookup #46

Terkwood opened this issue Apr 1, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@Terkwood
Copy link
Owner

Terkwood commented Apr 1, 2019

PickupManager and Inventory depend on each other. You have to declare an item_name in PickupManager, and it must map to a name in the lookup table in Inventory. That lookup table really should exist in its own file. There should be a less fragile link between PickupManager and that lookup table.
@Terkwood Terkwood mentioned this issue Apr 1, 2019
Merged
@Terkwood Terkwood added the enhancement New feature or request label Apr 1, 2019
@Terkwood
Copy link
Owner Author

When we peeked into the player's Inventory using the remote scene tree viewer, there didn't seem to be any items there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Terkwood