-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve perf #24
Comments
I might pick this up - doing perf things is fun and in this case it's Actually Good and not premature/over optimisation |
The perf issue is effectively 'if you have a really big markdown file, parsing takes a while' Vague idea: batching this markdown fetching, so critical markdown chunks are parsed first (may clash with how Joss has done the side nav as it relies on there being one document) Something else? |
I think the first thing would be parsing the markdown only once if people use the range selector so that the range selector actually feels usable with large files |
We were thinking of making the range selector on enter not constantly filtering. The biggest bottleneck IMO is that the loading spinner goes away, but nothing renders for maybe a second on large changelogs. If we could keep the spinner till markdown parse finished that would be good, or slight list virtualisation where we stagger adding markdown to the dom so top bits get added first, or detect that md parsing is still occurring and so keep the spinner and hide the |
Currently loading the markdown is painfully slow after being fetched. This kind of kills any joy in using the site. We should fix this. Open to ideas.
The text was updated successfully, but these errors were encountered: