[wishlist] Makefile: Add passed CFLAGS and LDFLAGS by environment to propsed flags

[carnil]

Hi

This is more a 'wishlist' bugreport: In Makefile for nodau there is:

CFLAGS ?= -Wall -g -pedantic -DTARGET="$(TARGET)" -DVERSION="$(VERSION)"
CLIBS ?= -lsqlite3 -lncurses -lcrypto

I would like to ask if it make sense, to change this to allow 'appending' some additional flags to the proposed, instead of completly overwrite if CFLAGS and CLIBS would be set. In Debian we are using dpkg-buildpackage to have some additional CFLAGS, CPPFLAGS, CXXFLAGS and LDFLAGS passed via environment (hardening flags).

Projects using e.g. automake use for this e.g. use of CFLAGS_AM AFAIK, for example. Cleary here using automake and co would be like using a sledgehammer to crack a nut.

What do you think? Would such a change be usefull too to others?

Please feel free to close this if this does not make sense or prefered to keep this way.

Regards,
Salvatore

[TicklishHoneyBee]

Hi Salvatore,

I just had a play with the makefile to put this in, as of the latest commit CFLAGS or CLIBS can be passed as environment variables. Doing so will extend the new NODAU_C{FLAG,LIB}S variables in the makefile.

Let me know if this suits your purposes, all I know is it still builds for me.