Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"When" form control in homepage planner not labeled correctly #29

Closed
NomeQ opened this issue Feb 5, 2021 · 2 comments
Closed

"When" form control in homepage planner not labeled correctly #29

NomeQ opened this issue Feb 5, 2021 · 2 comments
Assignees

Comments

@NomeQ
Copy link
Contributor

NomeQ commented Feb 5, 2021

We'll have to change up the base styles from the site here, because each input needs a label associated with it, and "When" is being applied to multiple elements. "Date" and "Time" need associated labels, as does the dropdown select, I suggest "Depart" for that label.

@ekeaton
Copy link
Collaborator

ekeaton commented Feb 5, 2021

@NomeQ I made my edits on index.php not new-home.php as that seemed to be the template actually being used. Let me know if i still need to make these edits if that's where you were already looking!

@NomeQ
Copy link
Contributor Author

NomeQ commented Feb 8, 2021

Still doesn't work - .obscure class that is used on the form labels uses display:none which will hide text from screen readers. Need to use a screen reader only class, and remove the obscure class.

The ideal would also be to have all labels visible, but since this is urgent, and styling will take some effort, I'll put that in the "nice to have column".

@ekeaton ekeaton closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants