Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient color contrast - list of elements to change #2593

Closed
kingalg opened this issue Aug 7, 2024 · 2 comments
Closed

Insufficient color contrast - list of elements to change #2593

kingalg opened this issue Aug 7, 2024 · 2 comments
Assignees
Labels

Comments

@kingalg
Copy link
Collaborator

kingalg commented Aug 7, 2024

For more details on issue check: #2592

Some elements had insufficient color contrast and Jason provided informations necessary to fixe it:

Blue links: Yes, this is deprecated. We have a darker blue (#1B6FEC) in our global Figma variables/tokens that we use for inline links such as these. It has a contrast of 4.63. Let's use this instead.
Placeholder text in forms: Perfect, I didn't catch this one, let's use #767676 for the placeholder text which is 4.54. I've added this to the global variables/tokens in Figma and set the placeholder text to use it in all forms.

Colors need to be replaced in below places (mobile and desktop):

  • placeholders in "Join community", "Create your community" and in general area users use to write a message,
  • links "create a new community", "join a community"
  • link that is send by users in message

Below you will find print screens from mentioned areas:
Screenshot 2024-08-07 at 14 10 30
Screenshot 2024-08-07 at 14 11 03
Screenshot 2024-08-07 at 14 15 26

@kingalg kingalg added this to Quiet Aug 7, 2024
@kingalg kingalg moved this to Backlog - Desktop & Backend in Quiet Aug 7, 2024
kingalg added a commit that referenced this issue Oct 16, 2024
@kingalg kingalg mentioned this issue Oct 16, 2024
4 tasks
@kingalg
Copy link
Collaborator Author

kingalg commented Oct 16, 2024

New and old color contrasts added in PR.

Screenshot 2024-10-15 at 14 30 46 Screenshot 2024-10-16 at 11 22 17

@kingalg kingalg moved this from Backlog - Desktop & Backend to Waiting for review in Quiet Oct 16, 2024
@kingalg kingalg self-assigned this Oct 16, 2024
kingalg added a commit that referenced this issue Nov 20, 2024
@kingalg kingalg moved this from Waiting for review to Merged in Quiet Nov 20, 2024
@islathehut islathehut added the 2.X v2.X label Dec 3, 2024
@adrastaea adrastaea moved this from Merged to Ready for QA in Quiet Dec 5, 2024
@kingalg
Copy link
Collaborator Author

kingalg commented Dec 20, 2024

Applied in version - 2.3.3-alpha.1 - checked and released.

@kingalg kingalg closed this as completed Dec 20, 2024
@kingalg kingalg moved this from Ready for QA to Done in Quiet Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants