Skip to content
This repository was archived by the owner on Jan 27, 2021. It is now read-only.

Commit 1d629e1

Browse files
authored
GEODE-8066: Pull up transitive dependency to clean up javax.activation and mail licenses. (apache#5291)
* correct dependency classpath test to remove javax.activation * fix assembly_content test * fix expected-jars test in gemfire-assembly:integrationTest * Drop 'activation v1.1.0' from src license file
1 parent 9d139b5 commit 1d629e1

File tree

9 files changed

+6
-22
lines changed

9 files changed

+6
-22
lines changed

boms/geode-all-bom/src/test/resources/expected-pom.xml

+3-3
Original file line numberDiff line numberDiff line change
@@ -140,9 +140,9 @@
140140
<scope>compile</scope>
141141
</dependency>
142142
<dependency>
143-
<groupId>com.sun.activation</groupId>
144-
<artifactId>javax.activation</artifactId>
145-
<version>1.2.0</version>
143+
<groupId>com.nimbusds</groupId>
144+
<artifactId>oauth2-oidc-sdk</artifactId>
145+
<version>8.9</version>
146146
<scope>compile</scope>
147147
</dependency>
148148
<dependency>

buildSrc/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy

+2-1
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,8 @@ class DependencyConstraints implements Plugin<Project> {
100100
api(group: 'com.healthmarketscience.rmiio', name: 'rmiio', version: '2.1.2')
101101
api(group: 'com.mockrunner', name: 'mockrunner-servlet', version: '2.0.4')
102102
api(group: 'com.nimbusds', name:'nimbus-jose-jwt', version:'8.11')
103-
api(group: 'com.sun.activation', name: 'javax.activation', version: '1.2.0')
103+
// Pinning transitive dependency from spring-security-oauth2 to clean up our licenses.
104+
api(group: 'com.nimbusds', name: 'oauth2-oidc-sdk', version: '8.9')
104105
api(group: 'com.sun.istack', name: 'istack-commons-runtime', version: '3.0.11')
105106
api(group: 'com.sun.mail', name: 'javax.mail', version: '1.6.2')
106107
api(group: 'com.sun.xml.bind', name: 'jaxb-impl', version: '2.3.2')

geode-assembly/src/integrationTest/resources/assembly_content.txt

-1
Original file line numberDiff line numberDiff line change
@@ -1020,7 +1020,6 @@ lib/istack-commons-runtime-3.0.11.jar
10201020
lib/jackson-annotations-2.10.1.jar
10211021
lib/jackson-core-2.10.1.jar
10221022
lib/jackson-databind-2.10.1.jar
1023-
lib/javax.activation-1.2.0.jar
10241023
lib/javax.activation-api-1.2.0.jar
10251024
lib/javax.mail-api-1.6.2.jar
10261025
lib/javax.resource-api-1.7.1.jar

geode-assembly/src/integrationTest/resources/dependency_classpath.txt

-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ log4j-api-2.13.1.jar
3232
spring-shell-1.2.0.RELEASE.jar
3333
rmiio-2.1.2.jar
3434
antlr-2.7.7.jar
35-
javax.activation-1.2.0.jar
3635
istack-commons-runtime-3.0.11.jar
3736
jaxb-impl-2.3.2.jar
3837
commons-validator-1.6.jar

geode-assembly/src/integrationTest/resources/expected_jars.txt

-3
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ HdrHistogram
22
HikariCP
33
LatencyUtils
44
accessors-smart
5-
activation
65
antlr
76
asm
87
byte-buddy
@@ -35,9 +34,7 @@ j2objc-annotations
3534
jackson-annotations
3635
jackson-core
3736
jackson-databind
38-
javax.activation
3937
javax.activation-api
40-
javax.mail
4138
javax.mail-api
4239
javax.resource-api
4340
javax.servlet-api

geode-assembly/src/main/dist/LICENSE

-2
Original file line numberDiff line numberDiff line change
@@ -264,8 +264,6 @@ The CDDL Version 1.1 (https://javaee.github.io/glassfish/LICENSE)
264264
Apache Geode bundles the following files under the Common Development and
265265
Distribution License:
266266

267-
- activation v1.1.0
268-
(https://www.oracle.com/java/technologies/java-beans-activation.html)
269267
- javax.activation v1.2.0
270268
(https://www.oracle.com/technetwork/java/javase/jaf-135115.html)
271269
- javax.mail v1.6.2 (http://www.oracle.com/)

geode-core/build.gradle

-2
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,6 @@ dependencies {
219219
//Commons validator is used to validate inet addresses in membership
220220
implementation('commons-validator:commons-validator')
221221

222-
//javax.activation is runtime dependency for gfsh with java 11 (used by gfsh-over-http)
223-
runtimeOnly('com.sun.activation:javax.activation')
224222

225223
//jaxb is used by cluster configuration
226224
implementation('javax.xml.bind:jaxb-api')

geode-core/src/test/resources/expected-pom.xml

-5
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,6 @@
237237
<artifactId>geode-tcp-server</artifactId>
238238
<scope>runtime</scope>
239239
</dependency>
240-
<dependency>
241-
<groupId>com.sun.activation</groupId>
242-
<artifactId>javax.activation</artifactId>
243-
<scope>runtime</scope>
244-
</dependency>
245240
<dependency>
246241
<groupId>com.sun.istack</groupId>
247242
<artifactId>istack-commons-runtime</artifactId>

geode-old-versions/build.gradle

+1-4
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,6 @@ subprojects {
7777
new File(contentsFile.toAbsolutePath().toString()).text = file(unpackDest).listFiles()
7878
}
7979
}
80-
project.assemble.dependsOn(project.downloadAndUnzipFile)
81-
project.assemble.dependsOn(project.enumerateArchiveContents)
82-
8380
}
8481
}
8582

@@ -119,7 +116,7 @@ project.createGeodeClasspathsFile.mustRunAfter(clean)
119116
project.createGeodeClasspathsFile.inputs.files(getTasksByName('downloadAndUnzipFile', true))
120117
project.createGeodeClasspathsFile.inputs.files(getTasksByName('enumerateArchiveContents', true))
121118
project.jarTest.dependsOn(createGeodeClasspathsFile)
122-
tasks.named('assemble') {
119+
tasks.named('build') {
123120
dependsOn(tasks.named('createGeodeClasspathsFile'))
124121
}
125122
sourceSets {

0 commit comments

Comments
 (0)