Tags: Uplordi/bitcoin-abc
Tags
[Cashtab] Center collapse headers in Send.js Summary: First step in task T2348. The headers of the three styled collapses in Send.js should be centered, with the arrow icon staying to the left of the collapse. Test Plan: cd web/cashtab && npm start navigate to the Send page observe that in each of the 3 styled collapses, the header is centered Reviewers: bytesofman, #bitcoin_abc Reviewed By: bytesofman, #bitcoin_abc Differential Revision: https://reviews.bitcoinabc.org/D11315
Use the actual config in the RPC console Summary: The Qt RPC console uses a default config and causes the RPC to behave slightly differently than they do from bitcoind. This diff fixes that by forwarding the config at execution time. Test Plan: ninja all check-all On the RPC console, run getnewaddress and check it returns an ecash address (was a legacy one before the patch). Reviewers: #bitcoin_abc, tyler-smith Reviewed By: #bitcoin_abc, tyler-smith Subscribers: Mengerian Differential Revision: https://reviews.bitcoinabc.org/D11370
[avalanche] Erase the avalanche nodes that get disconnected Summary: Right now only the nodes that failed to get queried after an attempt are removed from the avalanche datastructure. That means that there is no mechanims for removing nodes that never get selected for polling or are pending a proof should they get disconnected. This diff addresses this issue by having the avalanche processor implementing the `NetEventsInterface` and allowing the `CConnman` to take several of these interfaces. By doing so the processor gets notified on each node disconnection via the `FinalizeNode` method and can handle the node removal properly. This design would benefit from being turned into a proper notification handler with a register/unregister interface, but this is out of scope for this diff. Depends on D11300 and D11301 (prevent reverse lock on shutdown). Test Plan: With Clang and Debug: ninja all check-all Run the ASAN and TSAN builds. Reviewers: #bitcoin_abc, tyler-smith Reviewed By: #bitcoin_abc, tyler-smith Subscribers: tyler-smith Differential Revision: https://reviews.bitcoinabc.org/D11302
Fix the build on some platforms by using an explicit cast for Univalu… …e type Summary: It appears that std::vector::size_type is not implicitely convertible to uint64_t or int64_t on on platforms , so cast it explicitely. Test Plan: ./contrib/teamcity/build-configurations.py build-linux32 ./contrib/teamcity/build-configurations.py build-native-osx Reviewers: #bitcoin_abc, tyler-smith Reviewed By: #bitcoin_abc, tyler-smith Subscribers: tyler-smith Differential Revision: https://reviews.bitcoinabc.org/D11244
Run the activated tests using the next upgrade Summary: Replace axions with gluons. This causes the CI to check that the tests remain green after next upgrade. Depends on D11075. Test Plan: ninja check-upgrade-activated-extended Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D11080
specify the type when constructing unordered_set from iterator Summary: Fix a MacOS CI build failure ``` work/depends/SDKs/Xcode-11.3.1-11C505-extracted-SDK-with-libcxx-headers/usr/include/c++/v1/unordered_set:443:9: note: candidate template ignored: couldn't infer template argument '_Value' [11:46:20] [Step 1/1] unordered_set(_InputIterator __first, _InputIterator __last); ``` Test Plan: @bot build-osx Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D10990
[tests] Don't restrict MAX_NODES based on the list of pre-computed ad… …dresses Summary: The MAX_NODE constant from the test framework is used to compute the port number for the p2p interface and limit the number of network threads the framework can start. But the same constant is used to assert that no test is using more deterministic key that defined in the TestNode, which is completely unrelated. This means that MAX_NODE cannot be increased without pre computing a lot of keys even if no test is using more than the actual 12 defined. This diff decorrelates the constant from the number of deterministic keys so MAX_NODE can be increased without having to extend the keys at the same time, while improving the error message in case of misuse. This will make it possible to increase MAX_NODES in the future to add more outbound peer slots to the node, which will help gathering avalanche node addresses. There is no change in behavior since no test is actually using more than 12 nodes. Ref T1696. Test Plan: in util.py, increase `MAX_NODES` to something larger (I used 42, of course), then: ninja check-functional-extended Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Maniphest Tasks: T1696 Differential Revision: https://reviews.bitcoinabc.org/D10852
Remove the deprecated banscore field from the getpeerinfo RPC Summary: This is a follow up to D10802. This has been deprecated for long enough. Depends on D10802. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Subscribers: PiRK Differential Revision: https://reviews.bitcoinabc.org/D10803
PreviousNext