Rare crash related to chunk building

[jafkc2]

Bug Description

It's very rare to happen, I only experienced it 3 like times already, and I play a lot.

Reproduction Steps

• Play for some time in a server (no idea if this happens in singleplayer, probably)
• After some chunk update, if a very specific condition is met, the game will crash

Log File

[21:09:54] [Chunk Render Task Executor #0/ERROR]: Chunk build failed
net.minecraft.class_875: Encountered exception while building chunk meshes
at knot//net.caffeinemc.mods.sodium.client.render.chunk.compile.tasks.ChunkBuilderMeshingTask.fillCrashInfo(ChunkBuilderMeshingTask.java:219) ~[sodium-fabric-0.6.6-snapshot+mc1.8.9-local.jar:?]
at knot//net.caffeinemc.mods.sodium.client.render.chunk.compile.tasks.ChunkBuilderMeshingTask.execute(ChunkBuilderMeshingTask.java:151) ~[sodium-fabric-0.6.6-snapshot+mc1.8.9-local.jar:?]
at knot//net.caffeinemc.mods.sodium.client.render.chunk.compile.tasks.ChunkBuilderMeshingTask.execute(ChunkBuilderMeshingTask.java:51) ~[sodium-fabric-0.6.6-snapshot+mc1.8.9-local.jar:?]
at knot//net.caffeinemc.mods.sodium.client.render.chunk.compile.executor.ChunkJobTyped.execute(ChunkJobTyped.java:45) ~[sodium-fabric-0.6.6-snapshot+mc1.8.9-local.jar:?]
at knot//net.caffeinemc.mods.sodium.client.render.chunk.compile.executor.ChunkBuilder$WorkerRunnable.run(ChunkBuilder.java:215) ~[sodium-fabric-0.6.6-snapshot+mc1.8.9-local.jar:?]
at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]
Caused by: java.util.ConcurrentModificationException
at java.base/java.util.ArrayList$Itr.checkForComodification(ArrayList.java:1095) ~[?:?]
at java.base/java.util.ArrayList$Itr.remove(ArrayList.java:1063) ~[?:?]
at knot//net.minecraft.class_1150.method_8504(class_1150.java:1742) ~[client-intermediary.jar:?]
at knot//net.minecraft.class_1196.method_9138(class_1196.java:699) ~[client-intermediary.jar:?]
at knot//net.caffeinemc.mods.sodium.client.world.LevelSlice.method_8581(LevelSlice.java:384) ~[sodium-fabric-0.6.6-snapshot+mc1.8.9-local.jar:?]
at knot//net.caffeinemc.mods.sodium.client.render.chunk.compile.tasks.ChunkBuilderMeshingTask.execute(ChunkBuilderMeshingTask.java:129) ~[sodium-fabric-0.6.6-snapshot+mc1.8.9-local.jar:?]
... 4 more
[21:09:54] [Client thread/ERROR]: Minecraft has crashed!
net.fabricmc.loader.impl.FormattedException: java.lang.NegativeArraySizeException: -2
at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:63) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:482) ~[fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.9.jar:?]
at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) [fabric-loader-0.16.9.jar:?]
Caused by: java.lang.NegativeArraySizeException: -2
at knot//net.minecraft.class_1392.method_4432(class_1392.java:134) ~[client-intermediary.jar:?]
at knot//net.minecraft.class_1.method_6613(class_1.java:273) ~[client-intermediary.jar:?]
at knot//net.minecraft.class_1150.method_4684(class_1150.java:2790) ~[client-intermediary.jar:?]
at knot//net.minecraft.class_478.method_4684(class_478.java:309) ~[client-intermediary.jar:?]
at knot//net.minecraft.class_1600.method_2945(class_1600.java:12969) ~[client-intermediary.jar:?]
at knot//net.minecraft.class_1600.method_5580(class_1600.java:11560) ~[client-intermediary.jar:?]
at knot//net.minecraft.client.main.Main.main(Main.java:124) ~[fabric-loader-0.16.9-1.8.9.jar:?]
at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) ~[fabric-loader-0.16.9.jar:?]
... 2 more

Crash Report

Crash does not generate a crash report.

-- System Details --
Details:
Minecraft Version: 1.8.9
Operating System: Linux (amd64) version 6.12.9-3-cachyos
Java Version: 21.0.5, Oracle Corporation
Java VM Version: Java HotSpot(TM) 64-Bit Server VM (mixed mode, sharing), Oracle Corporation
Memory: 77874944 bytes (74 MB) / 207618048 bytes (198 MB) up to 3758096384 bytes (3584 MB)
JVM Flags: 21 total; -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -Xmx3584M -XX:+UnlockExperimentalVMOptions -XX:+UnlockDiagnosticVMOptions -XX:+AlwaysActAsServerClassMachine -XX:+AlwaysPreTouch -XX:+DisableExplicitGC -XX:NmethodSweepActivity=1 -XX:ReservedCodeCacheSize=400M -XX:NonNMethodCodeHeapSize=12M -XX:ProfiledCodeHeapSize=194M -XX:NonProfiledCodeHeapSize=194M -XX:-DontCompileHugeMethods -XX:+PerfDisableSharedMem -XX:+UseFastUnorderedTimeStamps -XX:+UseCriticalJavaThreadPriority -XX:+EagerJVMCI -XX:+UseTransparentHugePages
IntCache: cache: 0, tcache: 0, allocated: 0, tallocated: 0
Launched Version: fabric-loader-0.16.9-1.8.9
LWJGL: 3.3.5-snapshot
GL Caps:
Using VBOs: ERROR NullPointerException: Cannot read field "field_10330" because "this.field_3823" is null
Is Modded: Definitely; Client brand changed to 'fabric'
Type: Client (map_client.txt)
Resource Packs: ERROR NullPointerException: Cannot read field "field_7670" because "this.field_3823" is null
Current Language: ERROR NullPointerException: Cannot invoke "net.minecraft.class_1666.method_5942()" because "this.field_6278" is null
Profiler Position: N/A (disabled)
CPU:

[Luna0x01]

The stack trace points to internal game code. Looks like it’s a Minecraft bug we have to fix.

[Decencies]

Related line:

sodium/common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/compile/tasks/ChunkBuilderMeshingTask.java

Line 129 in 1bd2c5a

BlockEntity entity = slice.getBlockEntity(blockPos);

[Luna0x01]

Looks like the crash is related to block entities...