Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: broken links #16

Closed
alexandrascript opened this issue Feb 22, 2022 · 2 comments
Closed

README: broken links #16

alexandrascript opened this issue Feb 22, 2022 · 2 comments

Comments

@alexandrascript
Copy link

Hey folks,

The "here" link about opaque URL on line 83 of the README isn't working.

Therefore the URL of the ad is an opaque url (details here) — which can be used for rendering, but cannot be inspected directly.

I believe it should be updated to: https://github.com/shivanigithub/fenced-frame/blob/master/explainer/opaque_src.md

And I recommend updating the sentence for clarity, as there are often 2 URLs associated with an ad (the URL for the creative that loads in the ad slot and the URL that a user can click on, the conversion URL).

Therefore, the URL for the ad creative is an opaque url — which can be used for rendering, but cannot be inspected directly.

@alexandrascript alexandrascript changed the title README: OpaqueSrc link broken README: broken links Feb 22, 2022
@alexandrascript
Copy link
Author

alexandrascript commented Feb 22, 2022

Looks like several files were moved into sub-directories. Another example:

Unpartitioned storage access

The challenges of this use case is detailed in the document here.

Should be updated to:

Unpartitioned storage access

The challenges of this use case is detailed in Fenced frames and promptless unpartitioned storage access.

shivanigithub added a commit that referenced this issue Feb 22, 2022
Updated based on #16
@shivanigithub
Copy link
Collaborator

Thanks for the issue!
Updated both the links and the text for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants