Skip to content

Commit 31a21d9

Browse files
authored
docs: update contributing guide for code review (OverlayPlugin#8)
1 parent 2f99482 commit 31a21d9

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

CONTRIBUTING.md

+4-9
Original file line numberDiff line numberDiff line change
@@ -163,18 +163,13 @@ feel free to leave an issue/pull request in the repository.
163163

164164
### Code Review Culture
165165

166-
Ideally, all changes should get code review.
167-
Currently, since there's a shortage of people reviewing code.
168-
@quisquous just commits smaller changes directly,
169-
but this is not an ideal situation,
170-
especially since they make a lot of mistakes (sorry).
171-
Please feel free to leave comments about any of these commits
172-
or ask for more things to become pull requests.
173-
166+
All changes to the main branch require approval from a committer to the project.
174167
Any contributor to cactbot should feel welcome to chime in on any pull request,
175168
if you have ideas about how to make the code better
176-
(even if it's not part of the code you feel like you are an expert in).
169+
(even if it's not part of the code you feel like you are an expert in
170+
and even if you do not have commit access yourself).
177171
Pull requests are a collaborative effort!
172+
178173
There's a lack of good code reviewers at the moment,
179174
so feel encouraged to chip in as you have time and opinions.
180175

0 commit comments

Comments
 (0)