Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SNS logger][New event property] Catch a session closed event with property 'df_bot' #1314

Closed
ear-dev opened this issue Sep 29, 2022 · 1 comment · Fixed by WideChat/Apps.Dialogflow#177 or WideChat/Apps.Dialogflow#178

Comments

@ear-dev
Copy link

ear-dev commented Sep 29, 2022

There are some conversation flows where the session is closed by the bot. No appName/token being one. Another one is where the flow just comes to a natural conclusion and the visitor has no more questions.

We must be getting a flag from DF to close the session, and we should catch that in a new event.

let's make it this: {"close_method": "df_bot"} <- ?? - maybe DF.app?

@ear-dev ear-dev changed the title [SNS logger][New event property] Catch a session closed event with property 'closed_by_bot' [SNS logger][New event property] Catch a session closed event with property 'df_bot' Sep 29, 2022
@bhardwajaditya bhardwajaditya self-assigned this Nov 8, 2022
@ear-dev ear-dev reopened this Nov 15, 2022
@ear-dev
Copy link
Author

ear-dev commented Nov 15, 2022

@bhardwajaditya it looks like this event is catching more than just when we get the df_close_chat action payload from DF. I think it is also catching agentUnassigned, and maybe timeout? https://github.com/WideChat/Apps.Dialogflow/blob/master/handler/OnAgentUnassignedHandler.ts#L34

If we could find the spot where we exactly receive and parse the df_close_chat action, that would be more precise?

Can you take another look please? thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants