Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all done wtihout charset #2

Closed
steve02081504 opened this issue Oct 9, 2021 · 7 comments
Closed

all done wtihout charset #2

steve02081504 opened this issue Oct 9, 2021 · 7 comments
Assignees

Comments

@steve02081504
Copy link
Member

@ponapalt
All the work is done
Except for a problem with the encoding conversion
See https://github.com/Taromati2/ghost/runs/3844006038?check_suite_focus=true for an example

I don't know how to fix this coding problem, so if you do please change the code or let me know
Otherwise in CI we can only use the error message in English

@ponapalt
Copy link
Member

ponapalt commented Oct 9, 2021

yaya::char_t = wchar_t.
You can ignore the charset setting and just convert the yaya::char_t (wchar_t) to UTF-8 in loghandler.

steve02081504 added a commit that referenced this issue Oct 9, 2021
@steve02081504
Copy link
Member Author

steve02081504 commented Oct 9, 2021

yaya::char_t = wchar_t. You can ignore the charset setting and just convert the yaya::char_t (wchar_t) to UTF-8 in loghandler.

like 12557c4 ?

@steve02081504
Copy link
Member Author

https://github.com/Taromati2/ghost/actions/runs/1322327662
It looks like all the Chinese characters have turned into question marks

@ponapalt
Copy link
Member

ponapalt commented Oct 9, 2021

I think you can remove this problem as follows : just remove do_charset_convert and pass str to fwprintf directly.

@ponapalt
Copy link
Member

ponapalt commented Oct 9, 2021

Sorry, above solution is incomplete. Please check below URL.
https://blogs.osdn.jp/2020/04/24/wprintf.html
key point : _setmode(_fileno(stdout), _O_U8TEXT);

@steve02081504
Copy link
Member Author

Ohhhhhhhhh It's working!
thanks

@steve02081504
Copy link
Member Author

If you think there are function names that need tweaking just do it now, I think
Then we well ready to release the latest version of yaya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants