Skip to content

Commit b7c3b50

Browse files
author
mashuai
committed
change database name from string literal to a static final variable DATABASE_NAME
1 parent ab22b0a commit b7c3b50

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

src/main/java/edu/uci/ics/crawler4j/frontier/Counters.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ public static class ReservedCounterNames {
4747
public static final String PROCESSED_PAGES = "Processed-Pages";
4848
}
4949

50+
private static final String DATABASE_NAME = "Statistics";
5051
protected Database statisticsDB = null;
5152
protected Environment env;
5253

@@ -70,7 +71,7 @@ public Counters(Environment env, CrawlConfig config) {
7071
dbConfig.setAllowCreate(true);
7172
dbConfig.setTransactional(true);
7273
dbConfig.setDeferredWrite(false);
73-
statisticsDB = env.openDatabase(null, "Statistics", dbConfig);
74+
statisticsDB = env.openDatabase(null, DATABASE_NAME, dbConfig);
7475

7576
OperationStatus result;
7677
DatabaseEntry key = new DatabaseEntry();

src/main/java/edu/uci/ics/crawler4j/frontier/DocIDServer.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737

3838
public class DocIDServer extends Configurable {
3939

40+
private static final String DATABASE_NAME = "DocIDs";
4041
protected static final Logger logger = LoggerFactory.getLogger(DocIDServer.class);
4142

4243
protected Database docIDsDB = null;
@@ -51,7 +52,7 @@ public DocIDServer(Environment env, CrawlConfig config) {
5152
dbConfig.setAllowCreate(true);
5253
dbConfig.setTransactional(config.isResumableCrawling());
5354
dbConfig.setDeferredWrite(!config.isResumableCrawling());
54-
docIDsDB = env.openDatabase(null, "DocIDs", dbConfig);
55+
docIDsDB = env.openDatabase(null, DATABASE_NAME, dbConfig);
5556
if (config.isResumableCrawling()) {
5657
int docCount = getDocCount();
5758
if (docCount > 0) {

src/main/java/edu/uci/ics/crawler4j/frontier/Frontier.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
public class Frontier extends Configurable {
3737

3838
protected static final Logger logger = LoggerFactory.getLogger(Frontier.class);
39-
39+
private static final String DATABASE_NAME = "PendingURLsDB";
4040
protected WorkQueues workQueues;
4141

4242
protected InProcessPagesDB inProcessPages;
@@ -54,7 +54,7 @@ public Frontier(Environment env, CrawlConfig config) {
5454
super(config);
5555
this.counters = new Counters(env, config);
5656
try {
57-
workQueues = new WorkQueues(env, "PendingURLsDB", config.isResumableCrawling());
57+
workQueues = new WorkQueues(env, DATABASE_NAME, config.isResumableCrawling());
5858
if (config.isResumableCrawling()) {
5959
scheduledPages = counters.getValue(Counters.ReservedCounterNames.SCHEDULED_PAGES);
6060
inProcessPages = new InProcessPagesDB(env);

src/main/java/edu/uci/ics/crawler4j/frontier/InProcessPagesDB.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@
4040
public class InProcessPagesDB extends WorkQueues {
4141

4242
private static final Logger logger = LoggerFactory.getLogger(InProcessPagesDB.class);
43-
43+
private static final String DATABASE_NAME = "InProcessPagesDB";
4444
public InProcessPagesDB(Environment env) {
45-
super(env, "InProcessPagesDB", true);
45+
super(env, DATABASE_NAME, true);
4646
long docCount = getLength();
4747
if (docCount > 0) {
4848
logger.info("Loaded {} URLs that have been in process in the previous crawl.", docCount);

0 commit comments

Comments
 (0)