Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultCryptoService and SAN extensions #69

Closed
nodh opened this issue May 23, 2024 · 2 comments
Closed

DefaultCryptoService and SAN extensions #69

nodh opened this issue May 23, 2024 · 2 comments
Assignees
@JesusMcCloud
Labels
bug Something isn't working

Comments

@nodh
Copy link
Contributor

nodh commented May 23, 2024

Please reconsider adding the SAN extensions to the JVM default implementation just for one test

Also think about the iOS implementation, because the test for x509_san_dns in SIOP currently fails, see https://github.com/a-sit-plus/kmm-vc-library/actions/runs/9126951310/job/25096216868#step:5:496
@nodh nodh added the bug Something isn't working label May 23, 2024
@JesusMcCloud
Copy link
Collaborator

still relevant?

@nodh
Copy link
Contributor Author

nodh commented May 26, 2024

Fixed in #70

@nodh nodh closed this as completed May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JesusMcCloud JesusMcCloud

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nodh @JesusMcCloud