Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit esy.lock.json? #222

Closed
aantron opened this issue Aug 23, 2019 · 3 comments
Closed

Commit esy.lock.json? #222

aantron opened this issue Aug 23, 2019 · 3 comments
Milestone

Comments

@aantron
Copy link
Owner

aantron commented Aug 23, 2019

This should improve the installation of the BuckleScript package:

  • It would prevent surprise breakage from dependency changes.
  • It would consistently reuse the esy cache, since dependencies aren't changing.
@aantron aantron added this to the 1.5.0 milestone Aug 23, 2019
@aantron
Copy link
Owner Author

aantron commented Aug 23, 2019

It may have the downside, though, that installs will sometimes take longer, because Bisect_ppx needs old dependencies that aren't in cache for an esy user of projects that are keeping up with updates.

@aantron
Copy link
Owner Author

aantron commented Aug 23, 2019

A further disadvantage is that without esy.lock.json, if #220 is also solved, Bisect_ppx will automatically support future versions of BuckleScript when they change the OCaml compiler. if the underlying OMP is upgraded. So, without esy.lock.json, old releases of Bisect_ppx become forward-compatible, while with esy.lock.json, each release of Bisect_ppx is limited to some unknown future version of BuckleScript.

@aantron aantron closed this as completed Aug 23, 2019
@aantron
Copy link
Owner Author

aantron commented Aug 23, 2019

It's probably possible to have a partial esy.lock.

@aantron aantron reopened this Aug 23, 2019
@aantron aantron closed this as completed Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant