Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aaronjheng/mysql-go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: go-sql-driver/mysql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 17 commits
  • 23 files changed
  • 22 contributors

Commits on Nov 19, 2024

  1. Configuration menu
    Copy the full SHA
    41a5fa2 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Reduce "busy buffer" logs (go-sql-driver#1641)

    Reduce the use of `errBadConnNoWrite` to improve maintainability.
    
    ResetSession() and IsValid() checks if the buffer is busy. This reduces
    the risk of busy buffer error during connection in use. In principle,
    the risk of this is zero. So I removed errBadConnNoWrite when checking
    the busy buffer.
    
    After this change, only `writePacke()` returns errBadConnNoWrite.
    
    Additionally, I do not send COM_QUIT when readPacket() encounter read error.
    It caused "busy buffer" error too and hide real errors.
    methane authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9c8d6a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. stmt.Close() returns nil when double close (go-sql-driver#1642)

    ErrBadConn needs special care to ensure it is safe to retry.
    To improve maintenance, I don't want to use the error where I don't have to.
    
    Additionally, update the old comment about Go's bug that had been fixed long time ago.
    methane authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    2df7a26 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2024

  1. stop double-buffering (go-sql-driver#1643)

    Since we dropped Go 1.20 support, we do not need double buffering.
    
    This pull request stop double buffering and simplify buffer
    implementation a lot.
    
    Fix go-sql-driver#1435
    methane authored Dec 1, 2024
    Configuration menu
    Copy the full SHA
    575e1b2 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2024

  1. Configuration menu
    Copy the full SHA
    c9f41c0 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2024

  1. Implement zlib compression (go-sql-driver#1487)

    Implemented the SQL compression protocol. This new feature is enabled by:
    
    * Adding `compress=true` in DSN.
    * `cfg.Apply(Compress(True))`
    
    Co-authored-by: Brigitte Lamarche <[email protected]>
    Co-authored-by: Julien Schmidt <[email protected]>
    Co-authored-by: Jeffrey Charles <[email protected]>
    Co-authored-by: Jeff Hodges <[email protected]>
    Co-authored-by: Daniel Montoya <[email protected]>
    Co-authored-by: Justin Li <[email protected]>
    Co-authored-by: Dave Stubbs <[email protected]>
    Co-authored-by: Linh Tran Tuan <[email protected]>
    Co-authored-by: Robert R. Russell <[email protected]>
    Co-authored-by: INADA Naoki <[email protected]>
    Co-authored-by: Kieron Woodhouse <[email protected]>
    Co-authored-by: Alexey Palazhchenko <[email protected]>
    Co-authored-by: Reed Allman <[email protected]>
    Co-authored-by: Joe Mann <[email protected]>
    15 people authored Dec 19, 2024
    Configuration menu
    Copy the full SHA
    3348e57 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2024

  1. use binary.LittleEndian (go-sql-driver#1651)

    Recent Go does inlinine functions well.
    Using `LittleEndian.Put*` would better for readability and minimize bound check.
    
    Additionally, Go 1.19 introduced `LittleEndian.Append*`. It reduce more code.
    methane authored Dec 20, 2024
    Configuration menu
    Copy the full SHA
    b335ed3 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2024

  1. Configuration menu
    Copy the full SHA
    7403860 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2025

  1. better max_allowed_packet parsing (go-sql-driver#1661)

    Remove `stringToInt()` and use `strconv.Atoi` instead.
    methane authored Jan 22, 2025
    Configuration menu
    Copy the full SHA
    255d1ad View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2025

  1. Configuration menu
    Copy the full SHA
    85c6311 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2025

  1. Fix auth_switch_request packet handling

    auth_data contains last NUL.
    
    Fix go-sql-driver#1666
    
    Signed-off-by: Bes Dollma (bdollma) <[email protected]>
    bdollma-te authored Jan 29, 2025
    Configuration menu
    Copy the full SHA
    341a5a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2025

  1. fix flaky test. (go-sql-driver#1663)

    TestIssue1567 fails by max_connections error. This makes our CI unhappy.
    
    https://github.com/go-sql-driver/mysql/actions/runs/12904961433/job/35984402310
    methane authored Feb 18, 2025
    Configuration menu
    Copy the full SHA
    5d1bb8a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    58941dd View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2025

  1. Configuration menu
    Copy the full SHA
    c879816 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88ff88b View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2025

  1. go.mod: fix go version format (go-sql-driver#1682)

    As of Go 1.21, toolchain versions must use the 1.N.P syntax.
    https://go.dev/doc/toolchain#version
    methane authored Mar 14, 2025
    Configuration menu
    Copy the full SHA
    b84ac5a View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2025

  1. Configuration menu
    Copy the full SHA
    1fbafa8 View commit details
    Browse the repository at this point in the history
Loading