forked from sds/scss-lint
-
Notifications
You must be signed in to change notification settings - Fork 0
/
linter_spec.rb
343 lines (283 loc) · 7.54 KB
/
linter_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
require 'spec_helper'
describe SCSSLint::Linter do
describe 'control comments' do
let(:linter_config) { {} }
subject { SCSSLint::Linter::Fake.new }
module SCSSLint
class Linter::Fake < SCSSLint::Linter
def visit_root(_node)
add_lint(engine.lines.count, 'final new line') unless engine.lines[-1][-1] == "\n"
yield
end
def visit_prop(node)
return unless node.value.to_sass.strip == 'fail1'
add_lint(node, 'everything offends me')
end
def visit_class(klass)
return unless klass.to_s == '.badClass'
add_lint(klass, 'a bad class was used')
end
# Bypasses the visit order so a control comment might not be reached before a lint is
# added
def visit_rule(node)
node.children
.select { |child| child.is_a?(Sass::Tree::PropNode) }
.reject { |prop| prop.name.any? { |item| item.is_a?(Sass::Script::Node) } }
.each do |prop|
add_lint(prop, 'everything offends me 2') if prop.value.to_sass.strip == 'fail2'
end
yield
end
end
end
context 'when a disable is not present' do
let(:scss) { <<-SCSS }
p {
border: fail1;
a {
border: fail1;
}
}
SCSS
it { should report_lint }
end
context 'when a disable is present at the top level' do
let(:scss) { <<-SCSS.strip }
// scss-lint:disable Fake
p {
border: fail1;
a {
border: fail1;
}
}
SCSS
it { should_not report_lint }
end
context 'when a disable is present at the top level for another linter' do
let(:scss) { <<-SCSS }
// scss-lint:disable Bogus
p {
border: fail1;
}
p {
border: bogus;
}
SCSS
it { should report_lint lint: 3 }
end
context 'when a linter is disabled then enabled again' do
let(:scss) { <<-SCSS }
// scss-lint:disable Fake
p {
border: fail1;
}
// scss-lint:enable Fake
p {
border: fail1;
}
SCSS
it { should_not report_lint line: 3 }
it { should report_lint line: 7 }
end
context 'when a linter is disabled within a rule' do
let(:scss) { <<-SCSS }
p {
// scss-lint:disable Fake
border: fail1;
a {
border: fail1;
}
}
p {
border: fail1;
}
SCSS
it { should_not report_lint line: 3 }
it { should_not report_lint line: 6 }
it { should report_lint line: 11 }
end
context 'when more than one linter is disabled' do
let(:scss) { <<-SCSS }
// scss-lint:disable Bogus, Fake
p {
border: fail1;
}
p {
border: bogus;
}
SCSS
it { should_not report_lint }
end
context 'when more than one linter is disabled without spaces between the linter names' do
let(:scss) { <<-SCSS }
// scss-lint:disable Fake,Bogus
p {
border: fail1;
}
p {
border: Bogus;
}
SCSS
it { should_not report_lint }
end
context 'when more than one linter is disabled without commas between the linter names' do
let(:scss) { <<-SCSS }
// scss-lint:disable Fake Bogus
p {
border: fail1;
}
p {
border: bogus;
}
SCSS
it { should_not report_lint }
end
context 'when two linters are disabled and only one is reenabled' do
let(:scss) { <<-SCSS }
// scss-lint:disable Fake, Bogus
p {
border: fail1;
}
// scss-lint:enable Fake
p {
margin: fail1;
border: bogus;
}
SCSS
it { should_not report_lint line: 3 }
it { should report_lint line: 8 }
end
context 'when all linters are disabled' do
let(:scss) { <<-SCSS }
// scss-lint:disable all
p {
border: fail1;
}
p {
margin: fail1;
border: bogus;
}
SCSS
it { should_not report_lint }
end
context 'when all linters are disabled and then one is re-enabled' do
let(:scss) { <<-SCSS }
// scss-lint:disable all
p {
border: fail1;
}
// scss-lint:enable Fake
p {
margin: fail1;
border: bogus;
}
SCSS
it { should_not report_lint line: 3 }
it { should report_lint line: 8 }
end
context 'when a linter is bypassing the visit tree order' do
let(:scss) { <<-SCSS }
p {
// scss-lint:disable Fake
border: fail2;
}
SCSS
it { should_not report_lint }
end
context 'when the command comment is next to other comments' do
let(:scss) { <<-SCSS }
p {
// scss-lint:disable Fake
// more comments
border: fail2;
}
p {
// more comments
// scss-lint:disable Fake
border: fail2;
}
p {
background: red; // [1]
//scss-lint:disable Fake
border: fail2;
}
SCSS
it { should_not report_lint }
end
context 'when there are multiple consecutive command comments' do
let(:scss) { <<-SCSS }
// scss-lint:disable Fake
// scss-lint:disable Fake2
p {
border: fail1;
}
SCSS
it { should_not report_lint }
it 'disabled both linters' do
class SCSSLint::Linter::Fake2 < SCSSLint::Linter::Fake; end
SCSSLint::Linter::Fake2.new.should_not report_lint
end
end
context 'when the command comment is below an attached comment and a lint' do
let(:scss) { <<-SCSS }
// 1. Some comment about my background
.foo {
background: fail1; // [1]
// scss-lint:disable Fake
border: fail1
// scss-lint:enable Fake
}
SCSS
it { should report_lint line: 3 }
it { should_not report_lint line: 5 }
end
context 'when the command comment is at the end of a statement' do
let(:scss) { <<-SCSS }
p {
border: fail1; // scss-lint:disable Fake
border: fail1;
}
SCSS
it { should_not report_lint line: 2 }
it { should report_lint line: 3 }
end
context 'when global disable comes before an @include' do
let(:scss) { <<-SCSS }
// scss-lint:disable Fake
p {
border: fail1;
}
@include mixin(param) {
border: fail1;
}
SCSS
it { should_not report_lint }
end
context 'when // control comment appears in the middle of a comma sequence' do
let(:scss) { <<-SCSS }
.badClass, // scss-lint:disable Fake
.good-selector {
border: fail1;
}
p {
color: #FFF;
}
SCSS
it { should_not report_lint line: 1 }
it { should report_lint line: 3 }
end
context 'when /* control comment appears in the middle of a comma sequence' do
let(:scss) { <<-SCSS }
p {
color: #FFF;
}
.badClass, /* scss-lint:disable Fake */
.good-selector {
border: fail1;
}
SCSS
it { should_not report_lint line: 1 }
it { should report_lint line: 7 }
end
end
end