From 585c7d6dcea51a6c55b69dac5cf10b9f83e656de Mon Sep 17 00:00:00 2001 From: Arthur Casals <casals@users.noreply.github.com> Date: Wed, 7 Oct 2020 21:47:49 +0200 Subject: [PATCH 1/7] Update configuring-gradle-for-use-with-github-packages.md Fixes #145 --- .../configuring-gradle-for-use-with-github-packages.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/packages/using-github-packages-with-your-projects-ecosystem/configuring-gradle-for-use-with-github-packages.md b/content/packages/using-github-packages-with-your-projects-ecosystem/configuring-gradle-for-use-with-github-packages.md index 4dda592f46fa..15f40bfd8215 100644 --- a/content/packages/using-github-packages-with-your-projects-ecosystem/configuring-gradle-for-use-with-github-packages.md +++ b/content/packages/using-github-packages-with-your-projects-ecosystem/configuring-gradle-for-use-with-github-packages.md @@ -173,7 +173,7 @@ You can install a package by adding the package as a dependency to your project. {% data reusables.package_registry.authenticate-step %} 2. Add the package dependencies to your *build.gradle* file (Gradle Groovy) or *build.gradle.kts* file (Kotlin DSL) file. - Example using Grady Groovy: + Example using Gradle Groovy: ```shell dependencies { implementation 'com.example:package' @@ -188,7 +188,7 @@ You can install a package by adding the package as a dependency to your project. 3. Add the maven plugin to your *build.gradle* file (Gradle Groovy) or *build.gradle.kts* file (Kotlin DSL) file. - Example using Grady Groovy: + Example using Gradle Groovy: ```shell plugins { id 'maven' From 91cdaafa69774686138f99d94c9f684ef37b6be8 Mon Sep 17 00:00:00 2001 From: Arthur Casals <casals@users.noreply.github.com> Date: Thu, 8 Oct 2020 00:00:46 +0200 Subject: [PATCH 2/7] Update README.md Fixes #206 --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 7b0e43bef878..636d2592485e 100644 --- a/README.md +++ b/README.md @@ -26,6 +26,10 @@ As you're using the GitHub Docs, you may find something in an article that you'd If you've found a problem, you can open an issue using a [template](https://github.com/github/docs/issues/new/choose). +#### Solve an issue + +If you have a solution to one of the open issues, you will need to fork the repository and submit a PR using a [template](https://github.com/github/docs/blob/main/CONTRIBUTING.md#pull-request-template). For more details about this process, please check out [Getting Started with Contributing](/CONTRIBUTING.md). + #### Join us in discussions We use GitHub Discussions to talk about all sorts of topics related to documentation and this site. For example: if you'd like help troubleshooting a PR, have a great new idea, or want to share something amazing you've learned in our docs, join us in [discussions](https://github.com/github/docs/discussions). From e6f1f0a4c2d196a6252c1af8d8f2376f5e12d096 Mon Sep 17 00:00:00 2001 From: Simran <Simran-B@users.noreply.github.com> Date: Thu, 8 Oct 2020 10:13:26 +0200 Subject: [PATCH 3/7] Contributing: Fix links --- CONTRIBUTING.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0a15ad19a29c..f7160553dcb1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,7 +32,7 @@ Fork using the command line: ### Make your update: Make your changes to the file(s) you'd like to update. Here are some tips and tricks for [using the docs codebase](#working-in-the-githubdocs-repository). - Are you making changes to the application code? You'll need **Node.js v14** to run the site locally. See [contributing/development.md](contributing/development.md). - - Are you contributing to markdown? We use [GitHub Markdown](contributing/content-markup-reference). + - Are you contributing to markdown? We use [GitHub Markdown](contributing/content-markup-reference.md). ### Open a pull request When you're done making changes and you'd like to propose them for review, use the [pull request template](#pull-request-template) to open your PR (pull request). @@ -63,8 +63,7 @@ Now that you're a part of the GitHub Docs community, you can keep participating - [Starting with an issue](#starting-with-an-issue) - [Labels](#labels) - [Opening a pull request](#opening-a-pull-request) - - [Fork using GitHub Desktop](#fork-using-github-desktop) - - [Fork using the command line](#fork-using-the-command-line) + - [Fork using GitHub Desktop or the command line](#ready-to-make-a-change-fork-the-repo) - [Working in the github/docs repository](#working-in-the-githubdocs-repository) - [Resolving merge conflicts](#resolving-merge-conflicts) - [In the GitHub user interface](#in-the-github-user-interface) @@ -156,7 +155,7 @@ You should always review your own PR first. For content changes, make sure that you: - [ ] Confirm that the changes address every part of the content strategy plan from your issue (if there are differences, explain them). - [ ] Review the content for technical accuracy. -- [ ] Review the entire pull request using the [localization checklist](contribution/localization-checklist.md). +- [ ] Review the entire pull request using the [localization checklist](contributing/localization-checklist.md). - [ ] Copy-edit the changes for grammar, spelling, and adherence to the style guide. - [ ] Check new or updated Liquid statements to confirm that versioning is correct. - [ ] Check that all of your changes render correctly in staging. Remember, that lists and tables can be tricky. From 7e5aa0f729a9f0a4e87b30d5c077550403b800fd Mon Sep 17 00:00:00 2001 From: "allcontributors[bot]" <46447321+allcontributors[bot]@users.noreply.github.com> Date: Thu, 8 Oct 2020 17:42:14 +0000 Subject: [PATCH 4/7] docs: update README.md [skip ci] --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 30cb965b76f7..ddf314b5f978 100644 --- a/README.md +++ b/README.md @@ -113,6 +113,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d </tr> <tr> <td align="center"><a href="https://github.com/BenJam"><img src="https://avatars2.githubusercontent.com/u/158833?v=4" width="64px;" alt=""/><br /><sub><b>Benjamin Nickolls</b></sub></a><br /><a href="https://github.com/github/docs/commits?author=BenJam" title="Documentation">📖</a></td> + <td align="center"><a href="https://mcaffer.com"><img src="https://avatars2.githubusercontent.com/u/10070956?v=4" width="64px;" alt=""/><br /><sub><b>Jeff McAffer</b></sub></a><br /><a href="https://github.com/github/docs/commits?author=jeffmcaffer" title="Documentation">📖</a></td> </tr> </table> From f029d9863e84c224849df0e174d8f5779770ec56 Mon Sep 17 00:00:00 2001 From: "allcontributors[bot]" <46447321+allcontributors[bot]@users.noreply.github.com> Date: Thu, 8 Oct 2020 17:42:15 +0000 Subject: [PATCH 5/7] docs: update .all-contributorsrc [skip ci] --- .all-contributorsrc | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.all-contributorsrc b/.all-contributorsrc index 994a3ed16aab..29cbb44af1a4 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -294,6 +294,15 @@ "contributions": [ "doc" ] + }, + { + "login": "jeffmcaffer", + "name": "Jeff McAffer", + "avatar_url": "https://avatars2.githubusercontent.com/u/10070956?v=4", + "profile": "https://mcaffer.com", + "contributions": [ + "doc" + ] } ], "contributorsPerLine": 7, From 654857a0fd1f21d4c69f9269e754639d35afe980 Mon Sep 17 00:00:00 2001 From: Arthur Casals <casals@users.noreply.github.com> Date: Thu, 8 Oct 2020 20:41:40 +0200 Subject: [PATCH 6/7] Update README.md Suggested changes applied Co-authored-by: Janice <janiceilene@github.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 636d2592485e..e973ab972f41 100644 --- a/README.md +++ b/README.md @@ -28,7 +28,7 @@ If you've found a problem, you can open an issue using a [template](https://gith #### Solve an issue -If you have a solution to one of the open issues, you will need to fork the repository and submit a PR using a [template](https://github.com/github/docs/blob/main/CONTRIBUTING.md#pull-request-template). For more details about this process, please check out [Getting Started with Contributing](/CONTRIBUTING.md). +If you have a solution to one of the open issues, you will need to fork the repository and submit a PR using the [template](https://github.com/github/docs/blob/main/CONTRIBUTING.md#pull-request-template) that is visible automatically in the pull request body. For more details about this process, please check out [Getting Started with Contributing](/CONTRIBUTING.md). #### Join us in discussions From 5ed3c3bc96265b64a77e2b5dc2f8efde06c23352 Mon Sep 17 00:00:00 2001 From: Simran <Simran-B@users.noreply.github.com> Date: Thu, 8 Oct 2020 22:41:57 +0200 Subject: [PATCH 7/7] Remove link to fork repo Co-authored-by: Janice <janiceilene@github.com> --- CONTRIBUTING.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f7160553dcb1..673610d48848 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -63,7 +63,6 @@ Now that you're a part of the GitHub Docs community, you can keep participating - [Starting with an issue](#starting-with-an-issue) - [Labels](#labels) - [Opening a pull request](#opening-a-pull-request) - - [Fork using GitHub Desktop or the command line](#ready-to-make-a-change-fork-the-repo) - [Working in the github/docs repository](#working-in-the-githubdocs-repository) - [Resolving merge conflicts](#resolving-merge-conflicts) - [In the GitHub user interface](#in-the-github-user-interface)