Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Immediate jump into app on share (custom view) #86

Open
webdesign2be opened this issue Jul 15, 2024 · 7 comments
Open
Labels
enhancement New feature or request ios

Comments

@webdesign2be
Copy link

Describe the bug
When I open the share menu and click on my apps icon to share to it, I immediately leave the current app (safari in this case) and jump into my App.
I expected to stay in Safari and just send the shared URL into my app, possibly with some configuration.

To Reproduce
Just followed the initial steps to install and add default React code to my App.tsx.

Environment
System:
OS: macOS 15.0
CPU: (10) arm64 Apple M1 Max
Memory: 940.03 MB / 64.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 21.7.3
path: ~/.nvm/versions/node/v21.7.3/bin/node
Yarn:
version: 1.22.22
path: /opt/homebrew/bin/yarn
npm:
version: 9.8.0
path: /opt/homebrew/bin/npm
Watchman:
version: 2024.06.17.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.15.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.5
- iOS 17.5
- macOS 14.5
- tvOS 17.5
- visionOS 1.2
- watchOS 10.5
Android SDK: Not Found
IDEs:
Android Studio: 2024.1 AI-241.15989.150.2411.11948838
Xcode:
version: 15.4/15F31d
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.11
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.74.2
wanted: 0.74.2
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false

Additional context
Add any other context about the problem here.

  • expo version (ex: 49) : 51
  • using firebase : no
  • using static build : no
  • routing : react-navigation
  • package version: 2.3.0
  • platform target : iOS
  • device : simulator
  • type: local build
@JClackett
Copy link

This is a customised view, which I believe isn't supported yet in this package - it's in the readme

@achorein achorein added the enhancement New feature or request label Sep 13, 2024
@achorein
Copy link
Owner

I have to look into it, but adding an option for that seems possible.

@ice-cap0
Copy link

let's get the money

@ansh
Copy link

ansh commented Dec 8, 2024

It would be amazing to have that issue. I would happy to sponsor it via a github sponsorship, let me know

@achorein

@achorein
Copy link
Owner

achorein commented Dec 8, 2024

This feature seems long awaited, along with the famous “custom view”. I haven't developed it yet, as it implies a different behavior between iOS and Android, and therefore the implementation of two codes on your application. On my side, this requires a lot of work, with a change of architecture for the iOS part.

But I think I can now start working on it

  • First, I'm thinking of setting up a simple callback system, i.e. with a static “custom view” (non-modifiable) which, when validated, will call a async function provided in the app code.
  • Later, I'd like to make it possible to inject ReactNative code into this view.

@ansh I'd be glad if you could sponsor me on this part.

@achorein achorein changed the title Immediate jump into app on share Immediate jump into app on share (custom view) Dec 9, 2024
@achorein achorein added the ios label Dec 9, 2024
@achorein
Copy link
Owner

achorein commented Dec 10, 2024

@webdesign2be Rereading your message, I was wondering if your initial request isn't simpler than a “custom view”.
Is simply having a message indicating that sharing has been sent to the application enough?

  1. share from safari
  2. display a confirmation message
  3. close the sharing view with a simple “ok”.

in this case, it means that the share will not actually be processed until the user launches the application. A list of items waiting to be shared should also be managed.

@achorein achorein changed the title Immediate jump into app on share (custom view) [Feature Request] Immediate jump into app on share (custom view) Dec 13, 2024
@achorein
Copy link
Owner

I've modified the readme about “custom view” on iOS, take a look here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ios
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants