Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid hashing resources where possible #45

Open
aclysma opened this issue Jun 17, 2020 · 0 comments
Open

Avoid hashing resources where possible #45

aclysma opened this issue Jun 17, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@aclysma
Copy link
Owner

aclysma commented Jun 17, 2020

There are cases where out of convenience I'm just passing around raw data and hashing it instead of passing around just a hash. This is fine for prototyping but some of the data types that are being hashed are not trivial in size. This includes strings and vulkan config types (types.rs). In some cases we can benefit from a struct that contains both the hash and the original value the hash is based on, in other cases we can just use the hash. It would be ideal if we can have debug-only detection of hash collisions.

@aclysma aclysma added the good first issue Good for newcomers label Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant