Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify create_descriptor_set calls #72

Open
aclysma opened this issue Nov 22, 2020 · 0 comments
Open

Verify create_descriptor_set calls #72

aclysma opened this issue Nov 22, 2020 · 0 comments

Comments

@aclysma
Copy link
Owner

aclysma commented Nov 22, 2020

The API takes two inputs:

  • the descriptor set layout, created at runtime (possibly by loading an asset)
  • an auto-generated struct that's based on reflected shader data

These two parameters should be compatible, but there's no checking to ensure this. At debug time, we should consider validating the two match. This might be possible by hashing (maybe per-shader-type, i.e. just hash frag params and vertex params) or just do a full metadata compare. This can be at debug-time only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant