Test against 2.6, and development mode fixes

Also added some sensible rubocop defaults.

Author: BrianHawley

.codeclimate.yml

@@ -7,6 +7,7 @@ engines:
       - ruby
   rubocop:
     enabled: true
+    channel: rubocop-0-50
   reek:
     enabled: true
 ratings:

.rubocop.yml

@@ -0,0 +1,54 @@
+# Rubocop override settings
+
+AllCops:
+  TargetRubyVersion: 2.0
+
+Metrics/LineLength:
+  Max: 120
+  Exclude:
+    - config_module.gemspec
+    - "uspec/**/*"
+
+Naming/PredicateName:
+  Enabled: false
+
+Style/PreferredHashMethods:
+  Exclude:
+    - "**/*"
+
+Style/Documentation:
+  Enabled: false
+
+# FIXME: See issue #5
+Style/MethodMissing:
+  Enabled: false
+
+Style/MethodDefParentheses:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/SingleLineMethods:
+  Enabled: false
+
+Style/Alias:
+  Enabled: false
+
+Style/CaseEquality:
+  Enabled: false
+
+Style/SymbolArray:
+  Enabled: false
+
+Bundler/OrderedGems:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/StringLiteralsInInterpolation:
+  EnforcedStyle: double_quotes
+
+Layout/AccessModifierIndentation:
+  EnforcedStyle: outdent

.ruby-version

@@ -1 +1 @@
-ruby-2.3.3
+ruby-2.3.7

.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 rvm:
+  - 2.6
   - 2.5
   - 2.4
   - 2.3
@@ -8,19 +9,19 @@ rvm:
   - 2.0
 
   - ruby-head
-  - jruby-9.1.6.0
+  - jruby-9.2.7.0
   - jruby-21mode
 
 matrix:
   allow_failures:
     - rvm: ruby-head
-    - rvm: jruby-9.1.6.0
+    - rvm: jruby-9.2.7.0
     - rvm: jruby-21mode
 
 sudo: false
 
 before_install:
-  - gem update bundler
+  - which bundle || gem install bundler
 before_script:
   - bundle exec gem list
 script: bundle exec uspec

Gemfile

@@ -1,23 +1,33 @@
-source 'https://rubygems.org'
+# frozen_string_literal: true
+
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in config_module.gemspec
 gemspec
 
-if ENV['CI'] == 'true' then
+if ENV["CI"] == "true"
   group :test do
-    gem 'simplecov'
-    gem 'codeclimate-test-reporter', '~> 1.0.0'
+    gem "simplecov"
+    gem "codeclimate-test-reporter", "~> 1.0.0"
   end
 else
   group :development do
-    gem 'travis'
+    gem "travis"
+
+    if RUBY_VERSION.to_f < 2.2
+      byebug_version = "~> 9.0.6"
+    elsif RUBY_VERSION.to_f < 2.3
+      byebug_version = "~> 10.0.2"
+    elsif RUBY_VERSION.to_f < 2.4
+      byebug_version = "< 12"
+    end
+    gem "byebug", byebug_version
 
-    gem 'pry'
-    gem 'pry-doc'
-    gem 'pry-theme'
-    gem 'pry-rescue'
-    gem 'pry-byebug'
-    gem 'pry-coolline'
-    gem 'pry-stack_explorer'
+    gem "pry"
+    gem "pry-doc"
+    gem "pry-theme"
+    gem "pry-rescue"
+    gem "pry-byebug"
+    gem "pry-coolline"
   end
 end

Rakefile

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"

config_module.gemspec

@@ -1,22 +1,24 @@
-# -*- encoding: utf-8 -*-
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'config_module/version'
+require "config_module/version"
 
 Gem::Specification.new do |gem|
-  gem.name          = 'config_module'
-  gem.version       = ConfigModule::VERSION
-  gem.authors       = ['Anthony M. Cook']
-  gem.email         = ['github@anthonymcook.com']
-  gem.description   = %q{Wrap a configuration file in a module for easy use throughout your application. Inspired by Rails.}
-  gem.summary       = %q{Load important configuration files into their own modules!}
-  gem.homepage      = 'http://github.com/acook/config_module'
-  gem.licenses      = %w{MIT LGPL-3}
+  gem.name = "config_module"
+  gem.version = ConfigModule::VERSION
+  gem.authors = ["Anthony M. Cook"]
+  gem.email = ["github@anthonymcook.com"]
+  gem.description =
+    "Wrap a configuration file in a module for easy use throughout your application. Inspired by Rails."
+  gem.summary = "Load important configuration files into their own modules!"
+  gem.homepage = "http://github.com/acook/config_module"
+  gem.licenses = %w[MIT LGPL-3]
 
-  gem.files         = `git ls-files`.split($/)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
-  gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ['lib']
+  gem.files = `git ls-files`.split($/)
+  gem.executables = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
+  gem.test_files = gem.files.grep(%r{^(test|spec|features)/})
+  gem.require_paths = ["lib"]
 
-  gem.add_development_dependency 'uspec'
+  gem.add_development_dependency "uspec"
 end

lib/config_module.rb

@@ -1,10 +1,12 @@
-require 'ostruct'
-require 'yaml'
+# frozen_string_literal: true
 
-require_relative 'config_module/version'
-require_relative 'config_module/exceptions'
-require_relative 'config_module/config_option'
-require_relative 'config_module/config_helper'
+require "ostruct"
+require "yaml"
+
+require_relative "config_module/version"
+require_relative "config_module/exceptions"
+require_relative "config_module/config_option"
+require_relative "config_module/config_helper"
 
 module ConfigModule
   def [] key, *args
@@ -36,6 +38,6 @@ def __config_module_helper
   end
 
   def method_missing name, *args, &block
-    __config_module_helper.method_missing_handler name, caller(1), *args
+    __config_module_helper.method_missing_handler name, caller(1), *args, &block
   end
 end

lib/config_module/config_helper.rb

@@ -1,7 +1,10 @@
+# frozen_string_literal: true
+
 module ConfigModule
   class ConfigHelper
-    attr :raw_config
-    attr_accessor :config_file, :namespaces
+    attr_reader :raw_config
+    attr_accessor :config_file
+    attr_writer :namespaces
 
     def config
       @config ||= ConfigOption.wrap load_config
@@ -10,7 +13,7 @@ def config
     def method_missing_handler name, source, *args, &block
       ConfigOption.wrap config.send(name, *args, &block)
     rescue NoMethodError => error
-      if error.name == name then
+      if error.name == name
         raise(
           ConfigOption::NotFoundError.new(name, self, error),
           error.message, source
@@ -20,7 +23,7 @@ def method_missing_handler name, source, *args, &block
       end
     end
 
-    def field_lookup_handler name, source, *args, &block
+    def field_lookup_handler name, _source, *_args, &_block
       config[name]
     end
 
@@ -31,7 +34,7 @@ def load_config
     end
 
     def load_namespaces_from tree
-      namespaces.inject(ConfigOption.wrap tree) do |subtree, ns|
+      namespaces.inject(ConfigOption.wrap(tree)) do |subtree, ns|
         if ConfigOption === subtree && ns.respond_to?(:to_sym) && subtree.has_key?(ns)
           ConfigOption.wrap subtree[ns]
         else
@@ -41,15 +44,15 @@ def load_namespaces_from tree
           )
         end
       end
-    rescue TypeError => error
+    rescue TypeError
       raise(
         InvalidNamespaceError.new(namespaces.first, self, caller),
         "Namespace must be a string or symbol, instead it was: #{namespaces.first.class}", caller(6)
       )
     end
 
     def namespaces
-      @namespaces ||= Array.new
+      @namespaces ||= []
     end
   end
 end

lib/config_module/config_option.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 module ConfigModule
   class ConfigOption < OpenStruct
     include Enumerable
 
     def self.wrap data
-      if data.is_a? Hash then
+      if data.is_a? Hash
         ConfigOption.new data
       else
         data
@@ -12,7 +14,7 @@ def self.wrap data
 
     def each
       return to_enum __method__ unless block_given?
-      @table.each_pair{|p| yield p}
+      @table.each_pair { |p| yield p }
     end
 
     def [] name
@@ -26,7 +28,7 @@ def has_key? key
     def method_missing name, *args, &block
       result = super
 
-      if result || @table.has_key?(name) then
+      if result || @table.has_key?(name)
         self.class.wrap result
       else
         raise(

lib/config_module/exceptions.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 module ConfigModule
   class ConfigError < NoMethodError
     def initialize name, object, details = nil
       @name, @object, @details = name, object, details
       @custom_message = "invalid #{identifier} `#{name}' for #{object_info}"
     end
-    attr :name, :object, :details
+    attr_reader :name, :object, :details
 
     def custom_message
       @custom_message + "\n#{super_message}"
@@ -14,7 +16,7 @@ def custom_message
     alias_method :message, :custom_message
 
     def object_info
-      if object.is_a?(Class) then
+      if object.is_a?(Class)
         object.name
       else
         "instance of `#{object.class} < #{object.class.superclass}'"

lib/config_module/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ConfigModule
-  VERSION = '1.2.2'
+  VERSION = "1.2.2".freeze
 end

uspec/config_helper_spec.rb

@@ -1,12 +1,14 @@
-require_relative 'spec_helper'
+# frozen_string_literal: true
+
+require_relative "spec_helper"
 
 helper = ConfigModule::ConfigHelper.new
-helper.config_file = './config/example.yml'
+helper.config_file = "./config/example.yml"
 
-spec 'method_missing_handler traces back to the caller' do
+spec "method_missing_handler traces back to the caller" do
   begin
     helper.method_missing_handler :nonexistant, caller(1)
   rescue NoMethodError => error
-    error.backtrace.to_s.include? "spec/config_helper_spec.rb:6:in"
+    error.backtrace.to_s.include? "spec/config_helper_spec.rb:8:in"
   end
 end