Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported versions of Ruby and Rails #324

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

flavorjones
Copy link
Collaborator

  • Drop support for Ruby < 3.0 and Rails < 6.1
  • Add test coverage for Rails 8 (prerelease at the moment)
  • Bump action/checkout to avoid warnings

@kbrock Do you agree it's OK to drop these in the next release?

@flavorjones flavorjones requested a review from kbrock October 16, 2024 12:36
@flavorjones
Copy link
Collaborator Author

FWIW this was motivated by seeing these CI jobs fail this morning and deciding it's not worth the time to get them green again: https://github.com/active-hash/active_hash/actions/runs/11361403054/job/31601042743#step:3:195

Copy link
Collaborator

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


- v1.x: Ruby >= 1.9.3, Rails >= 2.2.2
- v2.x, v3.x: Ruby >= 2.4, Rails >= 5
- upcoming: Ruby >= 3.0, Rails >= 6.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try and ensure we put v3.0 here in our next changes

@kbrock kbrock merged commit 0d8b3e8 into master Oct 16, 2024
17 checks passed
@kbrock kbrock deleted the flavorjones-version-support-202410 branch October 16, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants