[WIP] [Proof of Concept] Virtual calculator keyboard on mobile transaction edit page #3790
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded
Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged No assets were unchanged |
|
Not sure if you've checked but when trying to modify things on the budget page the keypad covers nearly the entire modal, it appears to still inout what's typed but you can't see it |
Nice catch! I haven't noticed that since I was working on this on the mobile transaction page. We'll need to figure out a way to render the keyboard out of the modal. |
|
I keep looking for an enter key. Could that get added somewhere? |
Added an Enter key and a bunch more button. Some math operations should also now be supported within the mobile transaction edit page but there are still a few bugs here and there. |
|
Hrm, using the enter key saves the transaction, which is a bit awkward since entering the number is the first thing done - means the transaction has to be re-edited to finish adding in the details. Suggest having the enter key only exit the amount input box and closing the keyboard. Might feel better if it acted as a tab key, at least on transaction input anyway. Elsewhere as an exit box and don't focus another input would make more sense I think, but this behaviour could work on transactions too. The space button should probably be removed because it only enters zeroes? There's already a zero key - am I missing something? |
|
👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
joel-jeremy
force-pushed
the
mobile-calculator-keyboard
branch
from
ce26247 to
b9f062f
Compare
not sure if we are talking about the same thing, but it doesn't do auto decimals for number after the operator? also this might be a personal preference but i don't like the layout that much. i mean, all the calculator / number inputs i've used have had the numbers on the left side and operators etc on the right / on top |
|
👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review. |
POC for implementing a virtual keyboard on mobile which contains math operators (+, -, ×, ÷) to possibly support doing some calculations on the amount inputs (similar to how we can use math operators in desktop transactions page's amount fields).
Feedback or ideas are welcome!
#1556