[WIP] Fix issue where the UI is stuck sync'ing if no data from server #3941
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@matt-fidd Is this the logic we want? For me, this would result in 29 error messages. But in some sense that is correct, as I requested 29 accounts to sync. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
A user reported a problem where the server sent no data (it sent an empty
{}object). This results in the UI being "stuck" showing it synchronizing the banks forever.This detects the issue of an empty object and throws a
BankSyncexception.It also updates the SF batch sync code to properly handle if an exception happens, by setting every account to error status. I don't know if that is what we want, but it definitely reports an error and definitely stops it from being stuck.