Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certbot interfaces #73

Closed
wants to merge 52 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
3186774
Define new ABC classes
adferrand May 9, 2021
a8e03bb
Reimplement services with new ABC classes
adferrand May 9, 2021
809b872
Adapt plugins discovery and selection
adferrand May 9, 2021
b114f86
Remove zope interfaces from plugins
adferrand May 9, 2021
960c571
Re-enable delegation for simplicity
adferrand May 9, 2021
2543e78
Fix interfaces declaration
adferrand May 9, 2021
bc05d70
Remove interface implementer
adferrand May 9, 2021
edc5acf
Interfaces ordering
adferrand May 9, 2021
f836a40
Extract zope logic from discovery
adferrand May 9, 2021
1235feb
Cleanup imports
adferrand May 9, 2021
376f735
Fixing tests
adferrand May 9, 2021
e738f81
Fix main_test
adferrand May 9, 2021
e0afe58
Finish certbot unit tests
adferrand May 9, 2021
8ae22f5
Fix lint
adferrand May 9, 2021
a879e32
Various fixes thanks to mypy
adferrand May 9, 2021
f8d5892
Fix lint
adferrand May 9, 2021
d21eced
Order imports
adferrand May 9, 2021
a927aa5
Merge branch 'certbot-service' into certbot-interfaces
adferrand May 31, 2021
8bfa927
Align zope interfaces on ABC
adferrand May 31, 2021
29db0dc
Various fixes
adferrand May 31, 2021
7c0a676
Fix type
adferrand May 31, 2021
393bc9e
Merge branch 'certbot-service' into certbot-interfaces
adferrand May 31, 2021
2ed4e0a
Fixed typo in common.py (#8881)
GriffinSoftware Jun 3, 2021
78261db
Fix typo of fulfill in dns_rfc2136 plugin (#8886)
mimi89999 Jun 5, 2021
d7b26c1
cli: dont use argv[0] in user-facing messages (#8857)
alexzorin Jun 9, 2021
0b08a80
Pin pip & co like our other dependencies (#8868)
bmw Jun 10, 2021
0c63786
cli: improve error messages for enhance errors (#8884)
alexzorin Jun 10, 2021
b48e336
Allow nginx parser to handle empty file (#8895)
ohemorange Jun 10, 2021
c8255dd
Add --verbose-level flag and fix logging level calculations (#8900)
ohemorange Jun 10, 2021
18ea72f
Split out testing extras (#8893)
bmw Jun 11, 2021
d355562
certbot-apache: Add Void Linux overrides (#8891)
kartikynwa Jun 12, 2021
1b025e8
Adds njalla, DuckDNS and Porkbun 3rd party plugins (#8907)
chaptergy Jun 14, 2021
60a91eb
certonly: hide "NEXT STEPS" for dry-runs (#8901)
alexzorin Jun 14, 2021
bc7c953
cli: vary renewal advice for hookless manual certs (#8914)
alexzorin Jun 17, 2021
1e114b4
apache: configure nameless vhosts during auth (#8898)
alexzorin Jun 21, 2021
e5c41e7
standalone: add an auth_hint
alexzorin Jun 18, 2021
f137d84
acme.standalone: expose original socket.error
alexzorin Jun 18, 2021
62426ca
Merge pull request #8919 from alexzorin/standalone-error-ux
ohemorange Jun 21, 2021
8b61023
Adds Infonaniak 3rd party plugin (#8923)
reneluria Jun 25, 2021
667750f
docs: explain the situation with --manual renewal (#8911)
alexzorin Jun 28, 2021
d9a1850
Update changelog for 1.17.0 release
bmw Jul 6, 2021
952a296
Release 1.17.0
bmw Jul 6, 2021
d94cf0e
Add contents to certbot/CHANGELOG.md for next version
bmw Jul 6, 2021
9154592
Bump version to 1.18.0
bmw Jul 6, 2021
7ede5c3
Merge pull request #8933 from certbot/candidate-1.17.0
ohemorange Jul 6, 2021
2ab7857
Do not guess HTTP-01 response encoding (#8942)
bmw Jul 14, 2021
117791b
Remove unneeded certbot-auto files (#8938)
bmw Jul 14, 2021
8e29063
pylint: upgrade pinned verson and fix new lints (#8936)
alexzorin Jul 15, 2021
a105b58
apache: fix crash when authenticating empty vhosts (#8941)
alexzorin Jul 15, 2021
bebd399
acme: deprecate ACMEv1 client classes (#8931)
alexzorin Jul 15, 2021
10eecf9
Deprecate zope.component in favor of an direct calls to functions fro…
adferrand Jul 20, 2021
b38cbb4
Merge branch 'master' into certbot-interfaces
adferrand Jul 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Various fixes
  • Loading branch information
adferrand committed May 31, 2021
commit 29db0dc30f1fe4a27d30fbc8ef728f7d47ab0d15
1 change: 0 additions & 1 deletion certbot/certbot/display/obj.py
Original file line number Diff line number Diff line change
Expand Up @@ -542,4 +542,3 @@ def _parens_around_char(label):

"""
return "({first}){rest}".format(first=label[0], rest=label[1:])

2 changes: 1 addition & 1 deletion certbot/certbot/display/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@

class _DisplayService:
def __init__(self):
self.display: Optional[interfaces.IDisplay] = None
self.display: Optional[interfaces.Display] = None


_SERVICE = _DisplayService()
Expand Down
7 changes: 4 additions & 3 deletions certbot/certbot/interfaces.py
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ def notification(self, message: str, pause: bool = False, wrap: bool = True,
"""

@abstractmethod
def menu(self, message: str, choices: Union[List[str], Tuple[str], str],
def menu(self, message: str, choices: Union[List[str], Tuple[str, str]],
ok_label: Optional[str] = None, cancel_label: Optional[str] = None,
help_label: Optional[str] = None, default: Optional[int] = None,
cli_flag: Optional[str] = None, force_interactive: bool = False) -> Tuple[str, int]:
Expand All @@ -556,8 +556,9 @@ def menu(self, message: str, choices: Union[List[str], Tuple[str], str],

:param str message: message to display

:param choices: choices
:type choices: :class:`list` of :func:`tuple` or :class:`str`
:param choices: Menu lines, len must be > 0
:type choices: list of tuples (tag, item) or
list of descriptions (tags will be enumerated)

:param str ok_label: label for OK button (UNUSED)
:param str cancel_label: label for Cancel button (UNUSED)
Expand Down