chore: separate vars by distro, fix FD plugin integration #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add missing ansible collection requirement for community.general
* chore(lint): replace yes/no with true/false in molecule
adf-patrickha
changed the title
|
Back to draft. The rendered FD config ( |
instead of doing a convoluted loop to compare the lists between host_vars and the role vars, just use the vars once, as all plugins use the same values anyway. only the FileSet on the Director's side has to differ per plugin. Refs: https://docs.bareos.org/TasksAndConcepts/Plugins.html#file-daemon-plugins
|
OK, should finally be ready to review. @fadnincx can you have a look? |
fadnincx
reviewed
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://adfinis.github.io/ansible-guide/roles_collections.html#variables