-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The default template to create page does not contain thumbnail #43
Comments
@mohiaror the template is minimal to make the tests as lightweight as possible. Is the thumbnail a mandatory part? If it's missing, does it break any functionality? |
@volteanu It does not break any functionality per se but limits the scope of testing product code. We have a servlet which returns 200 HTTP status code if the thumbnail is present for the page or 302 redirect code if the thumbnail is not present and the redirection happens to the default thumbnail. We would like to test both the scenarios. It was possible to do that with the older we-retail based template. |
@volteanu Can we do it after the template has been created at [0]? We add the thumbnail by reading the inputstream and putting it after creating a node name thumbnail.png as a child of the template node? |
@volteanu Can you please help with an update here? Is this something which can be done as it will also help to achieve the parity between the older sample page and the one generated through this code? |
@mohiaror I've checked and it seems the JCR contentloader doesn't support binary data in JSON. The alternative would be to have a specialized rule that extends |
The default template [0] does not contain a thumbnail. Is this by design? If yes, will a test case requiring a page with thumbnail have to create its own template resource?
cc - @dulvac , @volteanu
[0] https://github.com/adobe/aem-testing-clients/blob/aem-cloud/src/main/resources/com/adobe/cq/testing/junit/rules/template.json
The text was updated successfully, but these errors were encountered: