You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A short subdomain length will treat the /static path as a subdomain
The get_subdomain_from_path function usually returns None due to the / after those paths. With a subdomain length <= 6 the / character is not considered and passes the set(subdomain) - alphabet_set != set() check
The text was updated successfully, but these errors were encountered:
Still not fixed. static should be a keyword, other paths are affected like logo.svg
For a 4-letter domain, the line subdomain = path[:length] truncates the input from static to stat and fails the check
Something like subdomain = path[:subdomain.find('/')] when it contains / might be a better fix
You're correct, it's static not public. Added it and a few others like logo, assets and favicon to keywords. I think that should be all.
Let me know if there's anything that I've missed in #49
A short subdomain length will treat the
/static
path as a subdomainThe
get_subdomain_from_path
function usually returnsNone
due to the/
after those paths. With a subdomain length <= 6 the/
character is not considered and passes theset(subdomain) - alphabet_set != set()
checkThe text was updated successfully, but these errors were encountered: