Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more direct and less error-prone return value #372

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Use a more direct and less error-prone return value #372

merged 1 commit into from
Dec 2, 2024

Conversation

pinglanlu
Copy link
Contributor

Since err != nil has been judged before, nil is returned directly here, which is more obvious, readable and less error-prone.

kroggen
kroggen approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@kroggen kroggen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@kroggen kroggen requested a review from hayarobi November 12, 2024 16:19
@pinglanlu
Copy link
Contributor Author

OK

Thank you for your approval.

@kroggen kroggen merged commit 7409e99 into aergoio:develop Dec 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroggen kroggen kroggen approved these changes

@hayarobi hayarobi Awaiting requested review from hayarobi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinglanlu @kroggen