Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jenkinsfile for CI and fix for consecutive messages #14

Merged
merged 2 commits into from
Jan 12, 2019

Conversation

praetp
Copy link

@praetp praetp commented Nov 26, 2018

I noticed consecutive consumer callbacks would still see old messages as well.
If the producer sends 'A', 'B', 'C', the consumer would receive

  • 'A'
  • 'A', 'B'
  • 'A', 'B', 'C'

Paul Praet added 2 commits November 23, 2018 14:39
Change-Id: I7ec385d309feee04e2c6844d8d599f65ad49d906
Change-Id: I6652e6135663b56439585944390b03b75450c260
@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #14 into master will not change coverage.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage     89.72%   89.72%           
  Complexity       70       70           
=========================================
  Files            10       10           
  Lines           185      185           
  Branches         20       20           
=========================================
  Hits            166      166           
  Misses           11       11           
  Partials          8        8
Impacted Files Coverage Δ Complexity Δ
...ertx/ext/web/handler/sse/impl/EventSourceImpl.java 91.22% <77.77%> (ø) 18 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033d8cd...ed9beca. Read the comment docs.

@aesteve
Copy link
Owner

aesteve commented Jan 12, 2019

Hello and thanks a lot for your work.

I'm so sorry I missed your PR. Since I never noticed issue with SSE on the server, I forgot about it.
I didn't even pay attention your PR was about the client, not the server.

Once again, thanks a lot for your work. I'm going to merge it, then delete the Jenkinsfile since the project is using travis and not Jenkins, but nevermind, thanks a lot for your interest and your work.

@aesteve aesteve merged commit b3bd2de into aesteve:master Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants