Allow support for scrubbing sensitive data from tapes

[tmtrademarked]

We're using OkReplay to write UI tests, and it's been working well for us so far! But one problem we've had with the library is that the generated tapes sometimes contain sensitive information like passwords/tokens/etc which we would prefer not to check in.

One solution that feels reasonable would be to allow us to create a TapeRoot which implements a Reader/Writer that knows how to replace sensitive data with safe tokens and vice versa. Unfortunately, AndroidTapeRoot is final, and the PermissionRule has a hard requirement of an AndroidTapeRoot instance.

Is there a better solution available for scrubbing out sensitive data before storing the tape? Alternately, could we just make AndroidTapeRoot non-final? Thoughts?

[felipecsl]

Great point! I think it would make sense to make AndroidTapeRoot non-final if that would resolve your immediate issue. I'll send a quick PR

[slott]

@tmtrademarked did you manage to get something working in terms of scrubbing the tapes ?
I'm in the exact same boat that you were in - and it would be nice if I didn't have to start from scratch.

[tmtrademarked]

Yes, I did - although it's not necessarily the most generic solution. I'm out of the office until next week, but I'll try to at least post something here then until I can get a pull request put together.

…

On Thu, May 24, 2018, 3:44 PM Morten Slott Hansen ***@***.***> wrote: @tmtrademarked <https://github.com/tmtrademarked> did you manage to get something working in terms of scrubbing the tapes ? I'm in the exact same boat that you were in - and it would be nice if I didn't have to start from scratch. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#60 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APUaZ0cI-Z_ktpOAE-Akd4pRRBz5dtd_ks5t1w2cgaJpZM4QnvZg> .