From 50bf7174b12b4fc90e4e50e6d50830b3cfebb390 Mon Sep 17 00:00:00 2001 From: Yuvi Panda Date: Tue, 4 Apr 2023 21:09:05 +0530 Subject: [PATCH 1/2] Bump to 3.0.0dev We're already on JupyterHub 4.x, so this makes sense from a semver perspective. Useful in generating better versions in https://hub.jupyter.org/helm-chart/. Credit to @pnasrat for pointing this out. --- chartpress.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chartpress.yaml b/chartpress.yaml index c141c82b95..6a1a973a2a 100644 --- a/chartpress.yaml +++ b/chartpress.yaml @@ -13,7 +13,7 @@ charts: # Dev: imagePrefix can be useful to override if you want to trial something # locally developed in a remote k8s cluster. imagePrefix: jupyterhub/k8s- - baseVersion: "2.0.1-0.dev" + baseVersion: "3.0.0-0.dev" repo: git: jupyterhub/helm-chart published: https://jupyterhub.github.io/helm-chart From c0d0b3b0d3458e959e655614766df44a29bf1993 Mon Sep 17 00:00:00 2001 From: Erik Sundell Date: Wed, 5 Apr 2023 16:09:03 +0200 Subject: [PATCH 2/2] Comment about how we aim to set baseVersion --- chartpress.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/chartpress.yaml b/chartpress.yaml index 6a1a973a2a..8b94b1bada 100644 --- a/chartpress.yaml +++ b/chartpress.yaml @@ -13,6 +13,11 @@ charts: # Dev: imagePrefix can be useful to override if you want to trial something # locally developed in a remote k8s cluster. imagePrefix: jupyterhub/k8s- + # baseVersion should be a -0.dev suffixed version, where the version should + # be the next major, minor, or patch version depending on what we have + # merged so far into the main branch. If for example we have merged a + # breaking change it should be the next major version, like 3.0.0-0.dev. + # baseVersion: "3.0.0-0.dev" repo: git: jupyterhub/helm-chart