You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the DataConverter, you have get which supports custom converters, but all the other methods like getArray do not. This should be rearchitected. You should make static Converter instances for all of the base types and initialize the typeToConverter map with all of them. Then even something like toInteger would be:
This is much more flexible and would really help. For instance, I have to convert an enum array, which is a string array but the oid is UNSPECIFIED but I can't override your array logic from the outside without extending the DataConverter class.
The text was updated successfully, but these errors were encountered:
In the DataConverter, you have
get
which supports custom converters, but all the other methods likegetArray
do not. This should be rearchitected. You should make staticConverter
instances for all of the base types and initialize thetypeToConverter
map with all of them. Then even something liketoInteger
would be:This is much more flexible and would really help. For instance, I have to convert an enum array, which is a string array but the oid is
UNSPECIFIED
but I can't override your array logic from the outside without extending theDataConverter
class.The text was updated successfully, but these errors were encountered: