Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requests[security] and the C tool chain #333

Closed
ewdurbin opened this issue Jan 18, 2018 · 2 comments
Closed

requests[security] and the C tool chain #333

ewdurbin opened this issue Jan 18, 2018 · 2 comments

Comments

@ewdurbin
Copy link

Hello!

Algolia has been super fun to learn and start working with.

I had one minor concern regarding the pinned dependency on requests[security].

We're using the client with AWS Lambda which makes C Dependencies a major pain in the butt.

Specifying the security extras on your package is an excellent idea, as it ensures that folks with older/out-of-date Python installations get a nice high quality TLS connection to your servers.

For folks running Modern Pythons™️ this is no longer necessary.

And unfortunately for folks running in AWS Lambda or other environments that make deploying pure python modules/dependencies easy, it's just a pain in the butt to add PyOpenSSL, cffi, and cyptography.

You could consider using PEP 508 Environment Markers to specify requests[security] for ancient Pythons, while letting folks running the good stuff skate away into the server less sunset :)

@LeoErcolanelli
Copy link

Hi there,

Thanks for the feedback!
As it turns out, requests itself is not compatible with the python versions that would have needed the flair, I just removed it.

The PR is here #335
I am just waiting for the reviewers to mark it as valid, and I will release a new version.

Thanks again!

@julienbourdeau
Copy link

I believe this was fixed by v1.15.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants