README enqueuing instructions are... a bit confusing

[vincentwoo]

For example, read the snippet for explaining how to trigger sidekiq queueing:

class Contact < ActiveRecord::Base
  include AlgoliaSearch

  algoliasearch enqueue: :trigger_sidekiq_worker do
    attribute :first_name, :last_name, :email
  end

  def self.trigger_sidekiq_worker(record, remove)
    MySidekiqWorker.perform_async(record.id, remove)
  end
end

class MySidekiqWorker
  def perform(id, remove)
    c = Contact.find(id)
    remove ? c.remove_from_index! : c.index!
  end
end

If a record is deleted, presumably the worker will be enqueued with the tuple id, true. At some later point, the worker will attempt to run Contact.find id and immediately throw an exception because that id will not be present in the table. Even if it didn't, somehow, what would be returned? Probably nil, since the record is gone. How then can you call remove_from_index! on c?

[vincentwoo]

As an aside, I know you have a more complete example above that handles deleting better, mostly I am confused as to why a sidekiq example that could never work is included.

There should also probably be a helper to get the computed Algolia index name from the model class!

[vincentwoo]

Found it!

This might be a better snippet for a general purpose algolia worker:

  # don't actually need removed parameter here, now
  def self.trigger_algolia_update record, removed
    AlgoliaSyncWorker.perform_async 'Contact', record.id
  end

class AlgoliaSyncWorker
    include Sidekiq::Worker

  def perform model_name, id
    klass = model_name.constantize
    record = klass.find_by_id id
    if record
      record.index!
    else
      Algolia::Index.new(klass.index_name).delete_object(id)
    end
  end
end

[redox]

Yes OK, that makes sense. Do you want to submit a PR @vincentwoo?

[vincentwoo]

no

[redox]

We'll tackle it while fixing #75