Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zombie compartment of DragNgoModoki_Fx3.7.uc.js #8

Closed
0rt opened this issue Nov 29, 2011 · 6 comments
Closed

zombie compartment of DragNgoModoki_Fx3.7.uc.js #8

0rt opened this issue Nov 29, 2011 · 6 comments

Comments

@0rt
Copy link

0rt commented Nov 29, 2011

Drag a link, open it in new tab will create a zombie compartment in about:memory.
Test under Fx nightly and only installed userchrome.js the extension and two script of yours: DragNgoModoki_Fx3.7.uc.js userchrome.js

@alice0775
Copy link
Owner

Umm, I can not reproduce.
Related compatiments ware released.And I can not notice any memory increasing.
Nightly11.0a1 11/30.

  1. Open about:memory and about:home
  2. Restart browser with session restore, look about:memory
  3. Switch about:home tab
  4. Drag drop "About Mozilla" in new tab
  5. Repeat step 4 10 times
  6. Close all "About Mozilla" tabs
  7. Wait for minutes
  8. look about:memory

@0rt
Copy link
Author

0rt commented Dec 1, 2011

You're right. If A drag a link in new Tab, say, B (About Mozilla in your procedure), B will be cleaned, but not A.
Some how about:home is an exception. Try this:
3. open www.mozilla.org
4. drag any link, say "about us" in new tab
5. no need repeating.

"about us" compartment will be gone after a while, but "www.mozilla.org" compartments will be there no matter how long you wait.

@alice0775
Copy link
Owner

Because you did not close tab(www.mozilla.org)...

@alice0775 alice0775 reopened this Dec 21, 2011
@0rt
Copy link
Author

0rt commented Dec 22, 2011

No, it was closed.

If A drag a link open tab B. Then A compartment stay when it's closed, in fact, even after all tab closed.

@Marina175
Copy link

autoContextmenu.uc.xulがFireGestures 1.6.6、All-in-One Gestures 0.22.1を導入していると機能しません

@0rt
Copy link
Author

0rt commented Jan 12, 2012

I had found out what is the problem: self.sourcenode is never delete, even after tab are close.
And of course it is replace by the latest new link, DragNGo.sourcenode is a single object.

switch (obj) {
case 'link':
  data = sourceNode;
  if (data instanceof HTMLAnchorElement) {
    var url = data.href;// self.getDroppedURL_Fixup(data.href);
    var baseURI = self.ioService.newURI(data.ownerDocument.documentURI, null, null);
    url = self.ioService.newURI(url, null, baseURI).spec;
    if (url) {
      info.urls.push(url);
      info.texts.push(gatherTextUnder(data));
      info.nodes.push(data);
      info.files.push(null);
      self.sourcenode = data; // Here store an object reference to the page
    }
  }
  break;

@0rt 0rt closed this as completed Feb 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants