From 8f37b92b9b89556847d4479d6ee87c3556f83fe6 Mon Sep 17 00:00:00 2001 From: deveshdama <87668846+deveshdama@users.noreply.github.com> Date: Fri, 6 Sep 2024 11:23:06 -0700 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Saverio Proto --- .../security/cert-manager-letsencrypt/readme.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/examples/azure-service-mesh/security/cert-manager-letsencrypt/readme.md b/examples/azure-service-mesh/security/cert-manager-letsencrypt/readme.md index f7055862..5af0d78b 100644 --- a/examples/azure-service-mesh/security/cert-manager-letsencrypt/readme.md +++ b/examples/azure-service-mesh/security/cert-manager-letsencrypt/readme.md @@ -100,7 +100,7 @@ this should print `Simple Bookstore App` Create a ConfigMap with the name `istio-shared-configmap-` in the `aks-istio-system` namespace to set `ingressService` and `ingressSelector`. For example, if your cluster is running asm-1-21 revision of mesh, then the ConfigMap needs to be named as istio-shared-configmap-asm-1-21. Mesh configuration has to be provided within the data section under mesh. ```shell -kubectl apply -f configmap.yaml +cat configmap.yaml | sed -e "s//${revision}/" | kubectl apply -f - ``` ### 5. Install cert-manager @@ -123,10 +123,11 @@ cert-manager-webhook-575479ff47-d87pf 1/1 Running 0 72s ### 6. Setup cluster-issuer and Certificate resources Set your email address in `cluster-issuer.yaml` that you'd like to register with ACME server. ```shell -kubectl apply -f cluster-issuer.yaml +EMAIL=email +cat cluster-issuer.yaml | sed -e "s/your-email-addr@domain.com/${EMAIL}/" | kubectl apply -f - kubectl apply -f certificate.yaml ``` -This should create k8s secret `bookinfo-certs` in `aks-istio-ingress` ns as requested by the certificate resource created above. +This should create k8s secret `bookinfo-certs` in `aks-istio-ingress` namespace as requested by the certificate resource created above. ```shell kubectl get secret -n aks-istio-ingress