From dc7c1e3e85fed4ecd522f8d1b36b2c3342b97ccf Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Tue, 9 Nov 2021 16:38:10 -0500 Subject: [PATCH 1/9] Adding branding to stack --- .github/stacks/stack.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/stacks/stack.yml b/.github/stacks/stack.yml index db53363..ea30fc4 100644 --- a/.github/stacks/stack.yml +++ b/.github/stacks/stack.yml @@ -1,6 +1,12 @@ -version: 0.0.2 +version: 0.2.1 + name: first-experiment description: This is a basic experiment leveraging the newly staff shipped GitHub Stacks feature. + +branding: + icon: 'cloud' + color: 'blue' + inputs: - name: required_approving_review_count description: Number of reviewers required to approve pull requests From 342aa82cab492305d7ffb14a0d585edffe40f450 Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Tue, 9 Nov 2021 16:51:01 -0500 Subject: [PATCH 2/9] Fixing stack config issue --- .github/stacks/stack.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/stacks/stack.yml b/.github/stacks/stack.yml index ea30fc4..7211c86 100644 --- a/.github/stacks/stack.yml +++ b/.github/stacks/stack.yml @@ -1,4 +1,4 @@ -version: 0.2.1 +version: 0.2.2 name: first-experiment description: This is a basic experiment leveraging the newly staff shipped GitHub Stacks feature. @@ -31,7 +31,8 @@ configs: parameters: allow-deletions: false allow-force-pushes: false - dismiss-stale-reviews: true enforce-admins: true - require-code-owner-reviews: true - required-approving_review_count: ${{ inputs.required_approving_review_count }} + required-pull-request-reviews: + dismiss-stale-reviews: true + require-code-owner-reviews: true + required-approving-review-count: ${{ inputs.required_approving_review_count }} From ae7cce277efdf5f87fb267f67994ad1d74848a7e Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Wed, 10 Nov 2021 09:08:59 -0500 Subject: [PATCH 3/9] Adding stack init - attempting to get this repository usable as a stack by adding init workflow --- .github/stacks/stack.yml | 2 ++ .github/workflows/stack-init.yml | 12 ++++++++++++ 2 files changed, 14 insertions(+) create mode 100644 .github/workflows/stack-init.yml diff --git a/.github/stacks/stack.yml b/.github/stacks/stack.yml index 7211c86..2dad761 100644 --- a/.github/stacks/stack.yml +++ b/.github/stacks/stack.yml @@ -36,3 +36,5 @@ configs: dismiss-stale-reviews: true require-code-owner-reviews: true required-approving-review-count: ${{ inputs.required_approving_review_count }} +init: + uses: "stack-init.yml" diff --git a/.github/workflows/stack-init.yml b/.github/workflows/stack-init.yml new file mode 100644 index 0000000..64e5f95 --- /dev/null +++ b/.github/workflows/stack-init.yml @@ -0,0 +1,12 @@ +name: Stack Init + +on: + workflow_dispatch: + +jobs: + stack-init: + runs-on: ubuntu-latest + steps: + - name: stub + run: | + echo "I really didn't want to be forced to create a workflow for a repo to be recognized as a stack but here goes nothing" From 577feba11ef518460754e573e37c49f3e7293b05 Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Wed, 10 Nov 2021 09:10:01 -0500 Subject: [PATCH 4/9] Bumping stack version --- .github/stacks/stack.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/stacks/stack.yml b/.github/stacks/stack.yml index 2dad761..41b278f 100644 --- a/.github/stacks/stack.yml +++ b/.github/stacks/stack.yml @@ -1,4 +1,4 @@ -version: 0.2.2 +version: 0.2.3 name: first-experiment description: This is a basic experiment leveraging the newly staff shipped GitHub Stacks feature. From e795b4d72e50ad9a2a78d684063509c562411928 Mon Sep 17 00:00:00 2001 From: Trilok Ramakrishna <84232154+3loka@users.noreply.github.com> Date: Wed, 10 Nov 2021 21:32:27 +0530 Subject: [PATCH 5/9] Update stack.yml --- .github/stacks/stack.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/stacks/stack.yml b/.github/stacks/stack.yml index 41b278f..14d35cd 100644 --- a/.github/stacks/stack.yml +++ b/.github/stacks/stack.yml @@ -1,4 +1,4 @@ -version: 0.2.3 +version: 0.1.0 name: first-experiment description: This is a basic experiment leveraging the newly staff shipped GitHub Stacks feature. From 3061b0615f66243d0944f34b59ef81588b22666f Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Wed, 10 Nov 2021 11:23:24 -0500 Subject: [PATCH 6/9] trying to get stack working --- .github/stacks/stack.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/stacks/stack.yml b/.github/stacks/stack.yml index 14d35cd..607cf19 100644 --- a/.github/stacks/stack.yml +++ b/.github/stacks/stack.yml @@ -12,7 +12,7 @@ inputs: description: Number of reviewers required to approve pull requests required: true default: 2 - valid-values: + validvalues: - 1 - 2 - 3 From ae13f599540c804280f905b5e44b58c147052bd6 Mon Sep 17 00:00:00 2001 From: Trilok Ramakrishna <84232154+3loka@users.noreply.github.com> Date: Wed, 10 Nov 2021 22:00:08 +0530 Subject: [PATCH 7/9] Update stack.yml --- .github/stacks/stack.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/stacks/stack.yml b/.github/stacks/stack.yml index 607cf19..9090490 100644 --- a/.github/stacks/stack.yml +++ b/.github/stacks/stack.yml @@ -22,7 +22,7 @@ inputs: - name: additional_self_hosted_runner_group description: Name of additional self-hosted runner group to requested for GitHub Actions workflows - valid-values: + validvalues: - Premium configs: From 206a6d18977bdfab6a99b6fc72bee9dc0912dee2 Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Wed, 10 Nov 2021 11:35:34 -0500 Subject: [PATCH 8/9] Addressing yamllint issues --- .github/stacks/stack.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/stacks/stack.yml b/.github/stacks/stack.yml index 9090490..36d34c7 100644 --- a/.github/stacks/stack.yml +++ b/.github/stacks/stack.yml @@ -1,11 +1,11 @@ -version: 0.1.0 +version: 0.1.0 name: first-experiment description: This is a basic experiment leveraging the newly staff shipped GitHub Stacks feature. branding: - icon: 'cloud' - color: 'blue' + icon: 'cloud' + color: 'blue' inputs: - name: required_approving_review_count From bf89530a2b8252f2045b7005e2de992803a1c127 Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Wed, 10 Nov 2021 13:47:39 -0500 Subject: [PATCH 9/9] Create README.md --- README.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 README.md diff --git a/README.md b/README.md new file mode 100644 index 0000000..1d2f6e2 --- /dev/null +++ b/README.md @@ -0,0 +1 @@ +# stacks-experiment