Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color for time #9

Open
ai opened this issue Jun 2, 2016 · 6 comments
Open

Color for time #9

ai opened this issue Jun 2, 2016 · 6 comments

Comments

@ai
Copy link

ai commented Jun 2, 2016

We should highligh plugin and file time in different colors — green for the fastest and red to the slowest

/cc @Gaserd

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

@ai Yeap 👍

@andywer
Copy link
Owner

andywer commented Jun 2, 2016

True. I also thought about that, but there are some detail issues:

Do we color by

  • relative time (slowest/fastest for current file)
  • relative time (slowest/fastest for all files)
  • absolute time (let's say everything < 5ms is green, > 10ms is red, color gradient for 5ms < time < 10ms )
    ?

I guess a good solution would have to consider all three metrics, but only show one combined color.

@andywer
Copy link
Owner

andywer commented Jun 2, 2016

PS: I just had an idea. I don't know if it's good or rather not, so I will just post it here:

We could ask the user for permission once and then sent simple anonymized benchmark reports to some server to gather statistics about the most popular postcss plugins and their performance benchmarks.

@Gaserd
Copy link
Contributor

Gaserd commented Jun 2, 2016

@andywer
I think relative time (slowest/fastest for current file)
And collection statistics this good idea

@ai
Copy link
Author

ai commented Jun 2, 2016

I think realtive time is fine too. Because the main purpose of coloring is to find slowest plugins and optimize them.

@1j01
Copy link

1j01 commented Oct 12, 2016

There should probably be an absolute cutoff though, like less than 5 or 10 ms is always green, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants