Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code seems incorrect #31

Closed
mukesh12z opened this issue Nov 18, 2018 · 1 comment
Closed

Code seems incorrect #31

mukesh12z opened this issue Nov 18, 2018 · 1 comment

Comments

@mukesh12z
Copy link

in Engine.start for below code:

Xs = [ data.iloc[i][var] for var in self.features ]

features are mentioned as ["EMA","SSO"] # i assume we need to map them to X1, X2.
iloc takes indexes as integers, it will not work as i.e; data.iloc[0]["EMA"] .

@anfederico
Copy link
Owner

The example data is not meant to go with the README tutorial. Therefore change EMA/SSO to X1/X2 respectively if you are using the example data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants