Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizzard "New Module": nothing happens when clicking on "Finish" #78

Closed
rehbein-dieter opened this issue Apr 24, 2017 · 13 comments
Closed
Milestone

Comments

@rehbein-dieter
Copy link

The wizzard to create a new angular 2 module does not work. Klicking on "Finish" does nothing.
Selecting the checkbox "Flat" does not change the "Generated Files".

@angelozerr
Copy link
Owner

Have you an error in the Log View?

@rehbein-dieter
Copy link
Author

Unfortunately not.

@angelozerr
Copy link
Owner

Please share your project

@angelozerr
Copy link
Owner

angelozerr commented Apr 24, 2017

Selecting the checkbox "Flat" does not change the "Generated Files".

@Springrbua is it normal?

@rehbein-dieter
Copy link
Author

Hm, I've just created a new empty project using the "New Angular 2 Project" Wizzard and that works fine.

The project, where I'm having the problem is a project, which was NOT created by your eclipse-plugin. Unfortunately I cannot share the project (it contains code for our customer which I'm not allowed to share).

I will try to reproduce the problem without the confidential code (but this may take some time).

Thanks for the quick response!

@rehbein-dieter
Copy link
Author

I now have a very small project, which I could share. How should I do that? (I have a zip-file with the entire project without the node-modules folder)

To reproduce (I'm using Eclipse Neon.3 with version 1.2.0 of your plugin on Windows 10):

  • unzip the file
  • in Eclipse: File/Import/General/Existing Projects into Workspace
  • select the project and import it
  • click the right mouse-button on the components folder (in src/app) and select new angular module
  • enter a module name (e.g. TestModule) and click "Finish" => nothing happens

@probert94
Copy link
Contributor

probert94 commented Apr 24, 2017

@rehbein-dieter Is there anything already running in the terminal?
I had a similar problem once, when I had multiple terminals open, of which some were already running a command (for example "ng serve").
Unfortunately I wasn't able to reproduce that.
Please try to close all the terminals and retry to generate a Module/Component etc.

@angelozerr I just had a look at the code and saw, that there is a little bug. The "generated files" do not react on the flat combobox. The command, however, should be executed correctly anyways.
To fix it you can only change this line to:
String folderName = isFlat() ? "" : cliJson.getFolderName(name);

EDIT:
I've just seen, that the flat-Combobox does not seem to have any logic yet...

@rehbein-dieter
Copy link
Author

I'v just created a new issue regarding the "Flat" checkbox (the command is missing the "--flat" option).

Regarding open terminals: yes, I have some terminals open, I'll check, if closing the terminals helps...

@probert94
Copy link
Contributor

@angelozerr Just had another look at the code and @rehbein-dieter is right, I forgot to implement the logic for the flat-option.
Sorry for that, I'll add it as soon as possible!

@angelozerr
Copy link
Owner

Sorry for that,

No pb @Springrbua !

I'll add it as soon as possible!

Thanks!

@rehbein-dieter
Copy link
Author

Regarding this issue: It seems, that I was simply too impatient. When I import the project into the workspace, I have to wait, until the javascript validation is finished (which takes some time, because the entire node-modules-folder seems to be validated). As soon as the validation is finished, the "new module" wizzard works as expected (except the flat option :-))

@probert94
Copy link
Contributor

@rehbein-dieter good to hear that. If it happens again, please let us know!

@probert94
Copy link
Contributor

@rehbein-dieter @angelozerr can we close this issue?

@angelozerr angelozerr added this to the 1.3.0 milestone May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants