From e62046c6d70f03c638ce0abdabd794313be64c38 Mon Sep 17 00:00:00 2001 From: Charles Lyding <19598772+clydin@users.noreply.github.com> Date: Mon, 31 Mar 2025 19:11:31 -0400 Subject: [PATCH] refactor(@angular/build): remove unneeded babel import attributes syntax plugin As of babel v7.26.0, the separate `@babel/plugin-syntax-import-attributes` package is no longer needed. The ability to parse import attributes is included by default. --- packages/angular/build/BUILD.bazel | 1 - packages/angular/build/package.json | 1 - .../build/src/tools/esbuild/javascript-transformer-worker.ts | 4 +--- pnpm-lock.yaml | 3 --- 4 files changed, 1 insertion(+), 8 deletions(-) diff --git a/packages/angular/build/BUILD.bazel b/packages/angular/build/BUILD.bazel index b337cd6a9e5b..3bc5b23802b8 100644 --- a/packages/angular/build/BUILD.bazel +++ b/packages/angular/build/BUILD.bazel @@ -81,7 +81,6 @@ ts_project( ":node_modules/@babel/core", ":node_modules/@babel/helper-annotate-as-pure", ":node_modules/@babel/helper-split-export-declaration", - ":node_modules/@babel/plugin-syntax-import-attributes", ":node_modules/@inquirer/confirm", ":node_modules/@vitejs/plugin-basic-ssl", ":node_modules/browserslist", diff --git a/packages/angular/build/package.json b/packages/angular/build/package.json index c27180fa01d1..8f119f2bcde4 100644 --- a/packages/angular/build/package.json +++ b/packages/angular/build/package.json @@ -23,7 +23,6 @@ "@babel/core": "7.26.10", "@babel/helper-annotate-as-pure": "7.25.9", "@babel/helper-split-export-declaration": "7.24.7", - "@babel/plugin-syntax-import-attributes": "7.26.0", "@inquirer/confirm": "5.1.8", "@vitejs/plugin-basic-ssl": "2.0.0", "beasties": "0.2.0", diff --git a/packages/angular/build/src/tools/esbuild/javascript-transformer-worker.ts b/packages/angular/build/src/tools/esbuild/javascript-transformer-worker.ts index 7bf29fc2e7a8..3d7c8d2ca126 100644 --- a/packages/angular/build/src/tools/esbuild/javascript-transformer-worker.ts +++ b/packages/angular/build/src/tools/esbuild/javascript-transformer-worker.ts @@ -61,9 +61,7 @@ async function transformWithBabel( options.sourcemap && (!!options.thirdPartySourcemaps || !/[\\/]node_modules[\\/]/.test(filename)); - // @ts-expect-error Import attribute syntax plugin does not currently have type definitions - const { default: importAttributePlugin } = await import('@babel/plugin-syntax-import-attributes'); - const plugins: PluginItem[] = [importAttributePlugin]; + const plugins: PluginItem[] = []; if (options.instrumentForCoverage) { const { default: coveragePlugin } = await import('../babel/plugins/add-code-coverage.js'); diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 623278178967..45db6b0b4b44 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -355,9 +355,6 @@ importers: '@babel/helper-split-export-declaration': specifier: 7.24.7 version: 7.24.7 - '@babel/plugin-syntax-import-attributes': - specifier: 7.26.0 - version: 7.26.0(@babel/core@7.26.10) '@inquirer/confirm': specifier: 5.1.8 version: 5.1.8(@types/node@20.17.27)