Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Killing a process linked to init process kills the node. #18

Open
mmzeeman opened this issue Jan 9, 2023 · 1 comment
Open

Killing a process linked to init process kills the node. #18

mmzeeman opened this issue Jan 9, 2023 · 1 comment

Comments

@mmzeeman
Copy link
Contributor

mmzeeman commented Jan 9, 2023

When havoc kills logger, heart or url_prim_loader it kills the entire node. Is this a feature or a bug? Or could it be that some internals of OTP has changed in such a way that havoc now tries to kill those processes?

I see that that havoc specifically checks to not kill application_controller, but there can be other processes linked to init too.

Would it be an idea to specifically check if a proces is linked to init? Or maybe introduce a configurable do_not_kill list with names of processes which should not be killed.

@ankhers
Copy link
Owner

ankhers commented Jan 9, 2023

It is possible logger, heart and url_prim_loader were added to OTP after I wrote this initial implementation. It should be easy enough to add them to the OTP_APPS definition that is currently used in order to not kill them by default.

There is already the killable_callback attribute that you can pass in the configuration in order to let you decide whether or not a given process should be killed. With that said, it is worth exploring whether other process should not be killed by default other than just the application_controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants