Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"send on closed channel" panics due to incorrect 'Close' method implementation #17

Open
antage opened this issue Sep 13, 2014 · 2 comments
Open

"send on closed channel" panics due to incorrect 'Close' method implementation #17

antage opened this issue Sep 13, 2014 · 2 comments
Assignees
@antage
Labels
bug

Comments

@antage
Copy link
Owner

antage commented Sep 13, 2014

See #16 as example.
We should ensure all goroutines are exited before close all control channels and other stuff.
@antage antage added the bug label Sep 13, 2014
@antage antage self-assigned this Sep 13, 2014
@antage antage mentioned this issue Sep 13, 2014
Closed
@flyingmutant
Copy link
Contributor

IMO #18 is a correct approach. What do you think?

@antage
Copy link
Owner Author

antage commented Sep 13, 2014

#18 hides the problem only.
I think a time for big refactoring has come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antage antage

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@antage @flyingmutant