You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Instead of copy-pasting, I'd actually prefer to use the include! macro.
Also, it would be nice to add a test that will check if we're missing some tests (to ease maintenance).
So, yes, we can start with the testcrate tests, so create a new crate similar to testcrate.
Since on stable we don't have the right position in the error message, it will be a compilefail (name to be checked) test instead of ui, so you'll need to update this line in the new crate.
Moreover, you won't need the .stderr files (because they belong to ui tests), but you'll need to update the error comments like this one in this testcrate crate because the new crate will only contains include!() macros.
Thanks for your help and if you need more info, feel free to ask.
To sum up:
Create a new crate compilefail-stable (or whatever name) in the tests folder.
Copy-paste the fail.rs from compilefail tests and change the mode to compilefail (or whatever the name is).
Create one with per compile fail test where each file contains an include!() macro call.
Add a normal Rust test (alongside fail) which will check that all the files in testcrate/tests/ui are in testcrate-stable/tests/fail.
Add the new command to launch this new test on stable in the travis file.
I just thought that using include!() might create issues with compiletest, so maybe we won't be able to use it (please test it).
By copy-pasting the files in this crate and creating a
compilefail
test instead of aui
test.The text was updated successfully, but these errors were encountered: