Release #1908
Merged
Release #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: image element rendering triggers an exception * chore: add image bugfix demo #1906
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
WalkthroughThis pull request introduces several changes across multiple packages, primarily focusing on updating dependencies and fixing issues related to image rendering. It includes changes to ESLint configurations, test cases for bug fixes, and updates to changelogs and package.json files for various packages. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
|
|
||
| // remove && expect no error | ||
| requestAnimationFrame(() => { | ||
| image.remove(); |
There was a problem hiding this comment.
The variable image is used before it is defined. This will lead to a runtime error. Consider defining image before using it in the requestAnimationFrame callback.
| @@ -244,7 +254,9 @@ export class ImageRenderer extends DefaultRenderer { | |||
| imageRect, | |||
| drawRect, | |||
| }); | |||
| } catch {} | |||
| } catch { | |||
| // expected error | |||
There was a problem hiding this comment.
Catching an empty block without handling or logging the error might lead to silent failures. Consider logging the error or handling it appropriately to avoid missing critical issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.