Skip to content
This repository has been archived by the owner on Feb 25, 2019. It is now read-only.

Volume directories not created #31

Closed
msamblanet opened this issue Sep 16, 2015 · 9 comments
Closed

Volume directories not created #31

msamblanet opened this issue Sep 16, 2015 · 9 comments

Comments

@msamblanet
Copy link
Contributor

When running nvl init, the resulting docker-compose.yml references a number of folders for mapping volumes that do not exist. I believe it would be best if these folders were created by the init process.

If the team agrees, I can provide a PR to add this to the initialization.

@adalinesimonian
Copy link
Member

What folders in particular seem to be the culprits?

@christiansmith
Copy link
Member

I'd guess views, email, public, keys... are there more?

@msamblanet
Copy link
Contributor Author

Just did a fresh build - the following volume directories did not exist:

Is it possible these are auto-created by docker-compose? They were not created by docker create or docker run...

@adalinesimonian
Copy link
Member

So the status quo is currently:

Directory Why it may not be there by default
connect/keys Created in unreleased version of connect-cli
connect/email Optional, only necessary if overwriting/adding email templates
connect/protocols Optional, only necessary if overwriting/adding protocol definitions
connect/providers Optional, only necessary if overwriting/adding provider definitions
connect/public Optional, only necessary if overwriting/adding static assets
connect/views Optional, only necessary if overwriting/adding view templates
redis/data ?
redis/logs #32
nginx/logs #32

@adalinesimonian
Copy link
Member

@christiansmith What's up with redis/data?

@christiansmith
Copy link
Member

redis/data I believe is created also when the containers are launched by docker compose.

@christiansmith
Copy link
Member

Given that not everyone using Docker will use Docker Compose, I think we should definitely create the mandatory directories with nvl init.

@msamblanet
Copy link
Contributor Author

I'll submit a CR for the "init' command to pre-create all the folders - should be up shortly. Even if not needed in all cases, it should not hurt.

christiansmith added a commit that referenced this issue Sep 16, 2015
connect-cli #31 - Precreate all folders for mounting docker volumes
@adalinesimonian
Copy link
Member

Fixed by #35

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants