diff --git a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java index 9fdaccf7681..d84f2a8188b 100644 --- a/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java +++ b/remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java @@ -326,11 +326,6 @@ public void updateNameServerAddressList(List addrs) { } } - @Override - public List getNameServerAddressList() { - return this.namesrvAddrList.get(); - } - @Override public RemotingCommand invokeSync(String addr, final RemotingCommand request, long timeoutMillis) throws InterruptedException, RemotingConnectException, RemotingSendRequestException, RemotingTimeoutException { @@ -540,6 +535,11 @@ public boolean isChannelWriteable(String addr) { return true; } + @Override + public List getNameServerAddressList() { + return this.namesrvAddrList.get(); + } + @Override public ChannelEventListener getChannelEventListener() { return channelEventListener; @@ -555,14 +555,6 @@ public ExecutorService getCallbackExecutor() { return this.publicExecutor; } - public List getNamesrvAddrList() { - return namesrvAddrList.get(); - } - - public RPCHook getRpcHook() { - return rpcHook; - } - static class ChannelWrapper { private final ChannelFuture channelFuture; @@ -600,8 +592,8 @@ class NettyConnectManageHandler extends ChannelDuplexHandler { @Override public void connect(ChannelHandlerContext ctx, SocketAddress remoteAddress, SocketAddress localAddress, ChannelPromise promise) throws Exception { - final String local = localAddress == null ? "UNKNOW" : localAddress.toString(); - final String remote = remoteAddress == null ? "UNKNOW" : remoteAddress.toString(); + final String local = localAddress == null ? "UNKNOWN" : localAddress.toString(); + final String remote = remoteAddress == null ? "UNKNOWN" : remoteAddress.toString(); log.info("NETTY CLIENT PIPELINE: CONNECT {} => {}", local, remote); super.connect(ctx, remoteAddress, localAddress, promise); @@ -638,8 +630,8 @@ public void close(ChannelHandlerContext ctx, ChannelPromise promise) throws Exce @Override public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exception { if (evt instanceof IdleStateEvent) { - IdleStateEvent evnet = (IdleStateEvent) evt; - if (evnet.state().equals(IdleState.ALL_IDLE)) { + IdleStateEvent event = (IdleStateEvent) evt; + if (event.state().equals(IdleState.ALL_IDLE)) { final String remoteAddress = RemotingHelper.parseChannelRemoteAddr(ctx.channel()); log.warn("NETTY CLIENT PIPELINE: IDLE exception [{}]", remoteAddress); closeChannel(ctx.channel());